Skip to content

Conversation

@bensherred
Copy link
Collaborator

@bensherred bensherred commented Nov 30, 2019

Important Information

I recommend bumping this package to a new major release. This library has been rewritten and all classes are different. It will require users to update their implementation.

The required PHP version has also been bumped to PHP 7.2 to support the latest versions of composer dependencies

Changelog

This PR continues on from and extends #9 which has been closed due to inactivity.

  • Seperated the tests into individual test classes
  • Removed hhvm from Travis CI config
  • Set the schema to always use HTTPS
  • Changed the way each request is handled (you can refer to the wiki for more information
  • We now have a model to represent each API endpoint including new properties
  • Simplified the README.md
  • Added extended documentation via the wiki
  • Remvoed the examples from the package (the wiki has plenty of examples)
  • Updated composer dependencies to the latest version
  • Set the minimum PHP version to PHP 7.2
  • Added PHP 7.2 to the Travis CI config

Future Development

If an API endpoint gets updated in the future, you can easily update the package by adding the new properties to the model or creating a new model all together.

You can also chain requests together like the company() request.

Copy link
Member

@ShawnCZek ShawnCZek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything seems to be alright now. Just let me know whether you want to publish this with finished documentation, or we can merge it as soon as we get other approvals.

Also, once this gets merged to develop, the license along with the composer files will be updated to hold the most recent information about all contributors correctly.

@bensherred
Copy link
Collaborator Author

Everything seems to be alright now. Just let me know whether you want to publish this with finished documentation, or we can merge it as soon as we get other approvals.

As it's a fairly big change, I think it would be best to have the documentation to go with it. I will try and finish the core documentation tonight 😃

@bensherred
Copy link
Collaborator Author

Sorry it's taken a bit longer than expected, but I believe all the initial documentation has been added to the Wiki. Happy to tweek things as things come up, but I think there is enough to publish a new release.

@ShawnCZek ShawnCZek merged commit f436835 into TruckersMP:develop Dec 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants