-
Couldn't load subscription status.
- Fork 15
Rework of the library #12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
… they're empty or not.
Co-Authored-By: ShawnCZek <shawnlupen@seznam.cz>
Co-Authored-By: ShawnCZek <shawnlupen@seznam.cz>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything seems to be alright now. Just let me know whether you want to publish this with finished documentation, or we can merge it as soon as we get other approvals.
Also, once this gets merged to develop, the license along with the composer files will be updated to hold the most recent information about all contributors correctly.
As it's a fairly big change, I think it would be best to have the documentation to go with it. I will try and finish the core documentation tonight 😃 |
Apply fixes from StyleCI
|
Sorry it's taken a bit longer than expected, but I believe all the initial documentation has been added to the Wiki. Happy to tweek things as things come up, but I think there is enough to publish a new release. |
Important Information
I recommend bumping this package to a new major release. This library has been rewritten and all classes are different. It will require users to update their implementation.
The required PHP version has also been bumped to PHP 7.2 to support the latest versions of composer dependencies
Changelog
This PR continues on from and extends #9 which has been closed due to inactivity.
Future Development
If an API endpoint gets updated in the future, you can easily update the package by adding the new properties to the model or creating a new model all together.
You can also chain requests together like the company() request.