Replace Guzzle 6 Adapter with Guzzle HTTP #26
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShawnCZek
reviewed
May 5, 2021
There was a problem hiding this comment.
Everything seems to be alright apart from the two little issues I mention in the comments.
Once these issues are resolved, I see no reason why not to approve this request.
Although, because of the changes to exceptions, I believe this has to be a part of the next major version. Therefore, it would be great to look for breaking changes we might want to do in it as well.
ShawnCZek
approved these changes
May 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the title suggests, this replaces the guzzle 6 adapter library with guzzle HTTP. This will solve issues when trying to use the package alongside the steam socialite package.
Closes #23 & #24