Implement (VTC) event endpoints #31
Conversation
Co-authored-by: Ben Sherred <ben@sherred.co.uk>
Co-authored-by: ShawnCZek <shawnlupen@seznam.cz>
There was a problem hiding this comment.
It is all looking okay now. I am just suggesting one minor change.
In the future tests need to be added to cover all parts of the events. They should be documented in the Wiki of this repository as well. However, that does not have to be a part of this pull request.
Co-authored-by: ShawnCZek <shawnlupen@seznam.cz>
|
@ShawnCZek Fixed that small change. Thank you for the code reviews! I by the way don't have access to propose changes for this package's GitHub wiki pages, it might've been restricted to collaborators only. |
There was a problem hiding this comment.
It is all looking great now. Thank you very much for such a huge pull request! 🚀
Feel free to add yourself to contributors in the composer.json file btw.
I have opened the wiki for everybody. But I am not sure how approving these changes works then. 👀
It turns out there is no approval system for wiki; exactly as I thought. This has been restricted once again.
3 participants
This PR closes #22.
Every event endpoint route that is documented has been added, including tests to verify their functionality.
All properties have been added & documented with DocBlocks, however, because of the lack of in-depth documentation for these endpoints, I could not find an accurate description for the
followingproperty of attendance users. This property is currently documented based on a guess; however, has been marked with aTODOin order to fix its description before merging :)Let me know if any changes or improvements are wanted! All feedback is welcome.