Fix failing tests due to company post no longer existing #25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShawnCZek
approved these changes
Apr 27, 2021
|
As discussed in DM's, the StyleCI changes were done because they became risky. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've mentioned this to @ShawnCZek in DM previously, but we shouldn't be calling the API during the tests. Instead, we should mock the response and then test the logic of the API Client. However, this PR fixes the failing tests. It looks like the company post no longer exists (another reason why we shouldn't be calling the API during the tests).
P.S. I've also had to bump the minimum PHP version to 7.3. Personally, I think this is fine due to PHP 7.2 no longer being maintained.