Skip to content

Conversation

@yordis
Copy link
Member

@yordis yordis commented Nov 8, 2025

No description provided.

@cursor
Copy link

cursor bot commented Nov 8, 2025

PR Summary

Formats generated defdelegate statements to multiline and inserts blank lines between delegates; updates tests accordingly.

  • Generator (cmd/protoc-gen-elixir-grpc):
    • Emit multi-line defdelegate with to: and as: on separate lines.
    • Insert a blank line between method delegates, but not after the last one.
  • Tests:
    • Update expected outputs across cases (options, prefixes, multiple services) to match new formatting.

Written by Cursor Bugbot for commit 0f542dd. This will update automatically on new commits. Configure here.

@coderabbitai
Copy link

coderabbitai bot commented Nov 8, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

Code generation functions in the Elixir gRPC protoc plugin are modified to reformat defdelegate statements across multiple lines and insert blank lines between method delegates (except after the last method). Test expectations are updated to match the new formatting output.

Changes

Cohort / File(s) Summary
Code generation formatting
cmd/protoc-gen-elixir-grpc/main.go
generateServiceModule now tracks method index and inserts blank lines between delegates; generateMethodDelegate reformats defdelegate emission from single-line to three-line structure (signature, to:, and as: on separate lines)
Test expectations
cmd/protoc-gen-elixir-grpc/main_test.go
Test assertions updated to match new multi-line defdelegate formatting in generated Elixir server code; no logic or test structure changes

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

  • Changes are primarily formatting and whitespace adjustments with consistent patterns across test cases
  • Single logic addition (blank-line insertion based on method index) is straightforward
  • No functional behavior, error handling, or API surface changes

Possibly related PRs

Poem

A rabbit hops through code so neat,
With spacing balanced, lines complete—
Each delegate now finds its place,
Three lines wide in formatted grace! 🐰✨

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch yordis/feat-server-opts-4

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 2944151 and 0f542dd.

📒 Files selected for processing (2)
  • cmd/protoc-gen-elixir-grpc/main.go (2 hunks)
  • cmd/protoc-gen-elixir-grpc/main_test.go (12 hunks)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

…odules

Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
@yordis yordis force-pushed the yordis/feat-server-opts-4 branch from e6300c9 to 0f542dd Compare November 8, 2025 05:04
@yordis yordis marked this pull request as ready for review November 8, 2025 05:05
@yordis yordis merged commit ea8a660 into main Nov 8, 2025
3 of 4 checks passed
@yordis yordis deleted the yordis/feat-server-opts-4 branch November 8, 2025 05:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants