Skip to content

chore: improve formatting of defdelegate statements in gRPC service modules #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yordis merged 1 commit into from
Nov 8, 2025
Merged

chore: improve formatting of defdelegate statements in gRPC service modules #29

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions cmd/protoc-gen-elixir-grpc/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -326,8 +326,13 @@ func generateServiceModule(content *strings.Builder, file *descriptorpb.FileDesc
}
content.WriteString("\n\n")

for _, method := range service.Method {
lastMethodIndex := len(service.Method) - 1
for i, method := range service.Method {
generateMethodDelegate(content, file, service, method, opts)
// Add blank line between delegates, but not after the last one
if i < lastMethodIndex {
content.WriteString("\n")
}
}

content.WriteString("end")
Expand All @@ -352,7 +357,9 @@ func generateMethodDelegate(content *strings.Builder, file *descriptorpb.FileDes
signature = fmt.Sprintf("%s(request, stream)", methodName)
}

content.WriteString(" defdelegate " + signature + ", to: " + handlerModuleName + ", as: :handle_message\n")
content.WriteString(" defdelegate " + signature + ",\n")
content.WriteString(" to: " + handlerModuleName + ",\n")
content.WriteString(" as: :handle_message\n")
}

func generateServiceModuleName(file *descriptorpb.FileDescriptorProto, service *descriptorpb.ServiceDescriptorProto) string {
Expand Down
67 changes: 51 additions & 16 deletions cmd/protoc-gen-elixir-grpc/main_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,10 +113,21 @@ defmodule Greeter.V1.GreeterService.Server do
use GRPC.Server,
service: Greeter.V1.GreeterService.Service

defdelegate say_hello(request, stream), to: Greeter.V1.GreeterService.Server.SayHelloHandler, as: :handle_message
defdelegate say_hello_stream(request, response_stream), to: Greeter.V1.GreeterService.Server.SayHelloStreamHandler, as: :handle_message
defdelegate say_hello_client_stream(request_stream, stream), to: Greeter.V1.GreeterService.Server.SayHelloClientStreamHandler, as: :handle_message
defdelegate say_hello_bidi_stream(request_stream, response_stream), to: Greeter.V1.GreeterService.Server.SayHelloBidiStreamHandler, as: :handle_message
defdelegate say_hello(request, stream),
to: Greeter.V1.GreeterService.Server.SayHelloHandler,
as: :handle_message

defdelegate say_hello_stream(request, response_stream),
to: Greeter.V1.GreeterService.Server.SayHelloStreamHandler,
as: :handle_message

defdelegate say_hello_client_stream(request_stream, stream),
to: Greeter.V1.GreeterService.Server.SayHelloClientStreamHandler,
as: :handle_message

defdelegate say_hello_bidi_stream(request_stream, response_stream),
to: Greeter.V1.GreeterService.Server.SayHelloBidiStreamHandler,
as: :handle_message
end
`
assert.Equal(t, expected, content)
Expand Down Expand Up @@ -168,7 +179,9 @@ defmodule Auth.V1.AuthService.Server do
use GRPC.Server,
service: Auth.V1.AuthService.Service

defdelegate login(request, stream), to: MyApp.Handlers.Auth.V1.AuthService.Server.LoginHandler, as: :handle_message
defdelegate login(request, stream),
to: MyApp.Handlers.Auth.V1.AuthService.Server.LoginHandler,
as: :handle_message
end
`
assert.Equal(t, expected, content)
Expand Down Expand Up @@ -221,7 +234,9 @@ defmodule Api.V1.ApiService.Server do
service: Api.V1.ApiService.Service,
http_transcode: true

defdelegate get(request, stream), to: Api.V1.ApiService.Server.GetHandler, as: :handle_message
defdelegate get(request, stream),
to: Api.V1.ApiService.Server.GetHandler,
as: :handle_message
end
`
assert.Equal(t, expected, content)
Expand Down Expand Up @@ -273,7 +288,9 @@ defmodule User.V1.UserService.Server do
use GRPC.Server,
service: User.V1.UserService.Service

defdelegate get_user(request, stream), to: User.V1.UserService.Server.GetUserHandler, as: :handle_message
defdelegate get_user(request, stream),
to: User.V1.UserService.Server.GetUserHandler,
as: :handle_message
end
`
assert.Equal(t, expected, content)
Expand Down Expand Up @@ -325,7 +342,9 @@ defmodule Billing.V1.BillingService.Server do
use GRPC.Server,
service: Billing.V1.BillingService.Service

defdelegate create_invoice(request, stream), to: MyApp.BusinessLogic.Billing.V1.BillingService.Server.CreateInvoiceHandler, as: :handle_message
defdelegate create_invoice(request, stream),
to: MyApp.BusinessLogic.Billing.V1.BillingService.Server.CreateInvoiceHandler,
as: :handle_message
end
`
assert.Equal(t, expected, content)
Expand Down Expand Up @@ -378,7 +397,9 @@ defmodule Payment.V1.PaymentService.Server do
service: Payment.V1.PaymentService.Service,
http_transcode: true

defdelegate process_payment(request, stream), to: MyApp.Core.Payment.V1.PaymentService.Server.ProcessPaymentHandler, as: :handle_message
defdelegate process_payment(request, stream),
to: MyApp.Core.Payment.V1.PaymentService.Server.ProcessPaymentHandler,
as: :handle_message
end
`
assert.Equal(t, expected, content)
Expand Down Expand Up @@ -431,7 +452,9 @@ defmodule Data.V1.DataService.Server do
service: Data.V1.DataService.Service,
codecs: [GRPC.Codec.Proto, GRPC.Codec.WebText, GRPC.Codec.JSON]

defdelegate get_data(request, stream), to: Data.V1.DataService.Server.GetDataHandler, as: :handle_message
defdelegate get_data(request, stream),
to: Data.V1.DataService.Server.GetDataHandler,
as: :handle_message
end
`
assert.Equal(t, expected, content)
Expand Down Expand Up @@ -484,7 +507,9 @@ defmodule Content.V1.ContentService.Server do
service: Content.V1.ContentService.Service,
codecs: [GRPC.Codec.Proto, GRPC.Codec.WebText, GRPC.Codec.JSON]

defdelegate get_content(request, stream), to: Content.V1.ContentService.Server.GetContentHandler, as: :handle_message
defdelegate get_content(request, stream),
to: Content.V1.ContentService.Server.GetContentHandler,
as: :handle_message
end
`
assert.Equal(t, expected, content)
Expand Down Expand Up @@ -537,7 +562,9 @@ defmodule Data.V1.DataService.Server do
service: Data.V1.DataService.Service,
compressors: [GRPC.Compressor.Gzip]

defdelegate get_data(request, stream), to: Data.V1.DataService.Server.GetDataHandler, as: :handle_message
defdelegate get_data(request, stream),
to: Data.V1.DataService.Server.GetDataHandler,
as: :handle_message
end
`
assert.Equal(t, expected, content)
Expand Down Expand Up @@ -592,7 +619,9 @@ defmodule Store.V1.StoreService.Server do
codecs: [GRPC.Codec.Proto, GRPC.Codec.JSON],
compressors: [GRPC.Compressor.Gzip]

defdelegate create_store(request, stream), to: MyApp.Business.Store.V1.StoreService.Server.CreateStoreHandler, as: :handle_message
defdelegate create_store(request, stream),
to: MyApp.Business.Store.V1.StoreService.Server.CreateStoreHandler,
as: :handle_message
end
`
assert.Equal(t, expected, content)
Expand Down Expand Up @@ -682,13 +711,17 @@ defmodule Test.V1.UserService.Server do
use GRPC.Server,
service: Test.V1.UserService.Service

defdelegate create_user(request, stream), to: Test.V1.UserService.Server.CreateUserHandler, as: :handle_message
defdelegate create_user(request, stream),
to: Test.V1.UserService.Server.CreateUserHandler,
as: :handle_message
end
defmodule Test.V1.ProductService.Server do
use GRPC.Server,
service: Test.V1.ProductService.Service

defdelegate create_product(request, stream), to: Test.V1.ProductService.Server.CreateProductHandler, as: :handle_message
defdelegate create_product(request, stream),
to: Test.V1.ProductService.Server.CreateProductHandler,
as: :handle_message
end
`
assert.Equal(t, expected, content)
Expand Down Expand Up @@ -740,7 +773,9 @@ defmodule SimpleService.Server do
use GRPC.Server,
service: SimpleService.Service

defdelegate do_something(request, stream), to: SimpleService.Server.DoSomethingHandler, as: :handle_message
defdelegate do_something(request, stream),
to: SimpleService.Server.DoSomethingHandler,
as: :handle_message
end
`
assert.Equal(t, expected, content)
Expand Down