Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the unnecessary scheduler.rs file #431

Merged
merged 1 commit into from
Nov 29, 2023

Conversation

steedmicro
Copy link
Contributor

@steedmicro steedmicro commented Nov 28, 2023

Description

After the rewrite of the build infrastructure, the project structure has changed successfully.

But currently we are having one unnecessary code file in the project - ./native-link-scheduler/src/scheduler.rs.

I confirmed all other source files are okay.

The detailed description can be found from the issue link below.

Fixes #430

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Please also list any relevant details for your test configuration

Checklist

  • Updated documentation if needed
  • Tests added/amended
  • bazel test //... passes locally
  • PR is contained in a single commit, using git amend see some docs

This change is Reviewable

Copy link
Member

@aaronmondal aaronmondal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh another oversight 😅 Yeah I split this into the worker_scheduler and action_scheduler files. The restructuring initially used a layout like this:

src/
  lib.rs
  scheduler.rs
  scheduler/
    someinternalfile.rs

Where all the things that are now native-link-somethin were just a single crate. That turned out to be too bad for build performance though so the final version split that up into the smaller crates that we have now. This is an artifact from that intermediary step.

:lgtm: ❤️

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @steed924)

@aaronmondal aaronmondal merged commit dd17524 into TraceMachina:main Nov 29, 2023
15 checks passed
TripleKai pushed a commit to TripleKai/turbo-cache that referenced this pull request Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove the unnecessary scheduler.rs file
2 participants