Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the unnecessary scheduler.rs file #430

Closed
steedmicro opened this issue Nov 28, 2023 · 0 comments · Fixed by #431
Closed

Remove the unnecessary scheduler.rs file #430

steedmicro opened this issue Nov 28, 2023 · 0 comments · Fixed by #431

Comments

@steedmicro
Copy link
Contributor

steedmicro commented Nov 28, 2023

After the rewrite of the build infrastructure, the project structure has changed successfully.

But currently we are having one unnecessary code file in the project - ./native-link-scheduler/src/scheduler.rs.

It doesn't exist in the ./native-link-scheduler/src/lib.rs file and it isn't imported from other parts of the project.

That file exists in the bazel build file ./native-link-scheduler/src/BUILD.bazel and this line should be removed.

https://github.com/TraceMachina/native-link/blob/4cc53bc82286cce57854f6e7c2765f03932ac370/native-link-scheduler/BUILD.bazel#L19

It seems like this file's content is splitted into two files - action_scheduler.rs and worker_scheduler.rs.

I've double-checked other files of the project and confirmed that other files are okay and they are imported at least once inside the project.

Having a duplicate and unncessary file inside the project might add complexity to the project structure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant