Append buck2 toolchain with additional packages #1264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A toolchain for buck2 depends on more than llvm and rust, appending more packages for compiling buck2 using remote execution on nativelink. This mirrors similar to what is used in [buck2/flake.nix](https://github.com/facebook/buck2/blob/main/flake.nix) `create-worker-experimental.nix` now flattens out the container image layout to a standard unix filesystem layout. Using the nix store layout requires client knowledge of toolchains and a similar setup as rbe gen/local remote execution which isn't available at the moment.
aaronmondal
approved these changes
Aug 14, 2024
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: 1 of 2 LGTMs obtained, and all files reviewed, and pending CI: Installation / macos-13, Remote / large-ubuntu-22.04 (waiting on @allada)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Append buck2 toolchain with additional packages
A toolchain for buck2 depends on more than llvm and rust,
appending more packages for compiling buck2 using remote
execution on nativelink. This mirrors similar to what is
used in buck2/flake.nix
create-worker-experimental.nixnow flattens out the containerimage layout to a standard unix filesystem layout. Using the
nix store layout requires client knowledge of toolchains and
a similar setup as rbe gen/local remote execution which isn't
available at the moment.
Fixes #1263
Type of change
How Has This Been Tested?
Build with nix and copy to local docker daemon.
Run a docker shell and inspected environment.
This change is