Repository navigation
Feature: Match Library and playlists tableviews with design - #132
Merged
GianniCarlo merged 3 commits intoJun 4, 2018
Merged
Conversation
Collaborator
|
There's a problem with the play/pause icon in the mini player |
Collaborator
Author
|
Seems I failed to fix the constraints, on it. |
added 3 commits
June 4, 2018 11:04
- Adjusted spacing and font sizes - centered progress - prepared BookCell for future enhancements
GianniCarlo
added a commit
that referenced
this pull request
Oct 5, 2026
A progress push now carries the book's lastPlayDate, as the Android app's does (bookplayer-android #130 and #132). The queued task already stored the date, but the push never read it. - Jellyfin gets LastPlayedDate. It stores a date only when a client sends one. - AudiobookShelf gets lastUpdate, in epoch milliseconds. Without it, ABS records when the push landed. It honors ours when updating an existing entry; a book's first write still takes the server's clock. The date is persisted with the task, like the position, so a stored value no real date has (NaN, infinite, past the year 5000) is left out instead of trapping the conversion on every pop. A task without a date sends none, and the server keeps or stamps its own.
GianniCarlo
added a commit
that referenced
this pull request
Oct 6, 2026
A progress push now carries the book's lastPlayDate, as the Android app's does (bookplayer-android #130 and #132). The queued task already stored the date, but the push never read it. - Jellyfin gets LastPlayedDate. It stores a date only when a client sends one. - AudiobookShelf gets lastUpdate, in epoch milliseconds. Without it, ABS records when the push landed. It honors ours when updating an existing entry; a book's first write still takes the server's clock. The date is persisted with the task, like the position, so a stored value no real date has (NaN, infinite, past the year 5000) is left out instead of trapping the conversion on every pop. A task without a date sends none, and the server keeps or stamps its own.
GianniCarlo
added a commit
that referenced
this pull request
Oct 7, 2026
A progress push now carries the book's lastPlayDate, as the Android app's does (bookplayer-android #130 and #132). The queued task already stored the date, but the push never read it. - Jellyfin gets LastPlayedDate. It stores a date only when a client sends one. - AudiobookShelf gets lastUpdate, in epoch milliseconds. Without it, ABS records when the push landed. It honors ours when updating an existing entry; a book's first write still takes the server's clock. The date is persisted with the task, like the position, so a stored value no real date has (NaN, infinite, past the year 5000) is left out instead of trapping the conversion on every pop. A task without a date sends none, and the server keeps or stamps its own.
GianniCarlo
added a commit
that referenced
this pull request
Oct 10, 2026
A progress push now carries the book's lastPlayDate, as the Android app's does (bookplayer-android #130 and #132). The queued task already stored the date, but the push never read it. - Jellyfin gets LastPlayedDate. It stores a date only when a client sends one. - AudiobookShelf gets lastUpdate, in epoch milliseconds. Without it, ABS records when the push landed. It honors ours when updating an existing entry; a book's first write still takes the server's clock. The date is persisted with the task, like the position, so a stored value no real date has (NaN, infinite, past the year 5000) is left out instead of trapping the conversion on every pop. A task without a date sends none, and the server keeps or stamps its own.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re #129