Skip to content

Feature: Renaming playlists from the Library - #130

Merged
GianniCarlo merged 1 commit into
TortugaPower:next/majorfrom
pichfl:feature/rename-playlist
Jun 4, 2018
Merged

GianniCarlo merged 1 commit into
TortugaPower:next/majorfrom
pichfl:feature/rename-playlist

Conversation

@pichfl

@pichfl pichfl commented Jun 3, 2018

Copy link
Copy Markdown
Collaborator

Re #96

@pichfl pichfl added this to the v3.0.0 milestone Jun 3, 2018
@pichfl
pichfl requested a review from GianniCarlo June 3, 2018 15:54
@pichfl pichfl changed the title Feature: Make playlists renamable Feature: Renaming playlists from the Library Jun 3, 2018
@GianniCarlo
GianniCarlo merged commit 06836f8 into TortugaPower:next/major Jun 4, 2018
@pichfl
pichfl deleted the feature/rename-playlist branch June 4, 2018 09:03
GianniCarlo added a commit that referenced this pull request Oct 5, 2026
A progress push now carries the book's lastPlayDate, as the Android app's does
(bookplayer-android #130 and #132). The queued task already stored the date,
but the push never read it.

- Jellyfin gets LastPlayedDate. It stores a date only when a client sends one.
- AudiobookShelf gets lastUpdate, in epoch milliseconds. Without it, ABS
  records when the push landed. It honors ours when updating an existing
  entry; a book's first write still takes the server's clock.

The date is persisted with the task, like the position, so a stored value no
real date has (NaN, infinite, past the year 5000) is left out instead of
trapping the conversion on every pop. A task without a date sends none, and
the server keeps or stamps its own.
GianniCarlo added a commit that referenced this pull request Oct 6, 2026
A progress push now carries the book's lastPlayDate, as the Android app's does
(bookplayer-android #130 and #132). The queued task already stored the date,
but the push never read it.

- Jellyfin gets LastPlayedDate. It stores a date only when a client sends one.
- AudiobookShelf gets lastUpdate, in epoch milliseconds. Without it, ABS
  records when the push landed. It honors ours when updating an existing
  entry; a book's first write still takes the server's clock.

The date is persisted with the task, like the position, so a stored value no
real date has (NaN, infinite, past the year 5000) is left out instead of
trapping the conversion on every pop. A task without a date sends none, and
the server keeps or stamps its own.
GianniCarlo added a commit that referenced this pull request Oct 7, 2026
A progress push now carries the book's lastPlayDate, as the Android app's does
(bookplayer-android #130 and #132). The queued task already stored the date,
but the push never read it.

- Jellyfin gets LastPlayedDate. It stores a date only when a client sends one.
- AudiobookShelf gets lastUpdate, in epoch milliseconds. Without it, ABS
  records when the push landed. It honors ours when updating an existing
  entry; a book's first write still takes the server's clock.

The date is persisted with the task, like the position, so a stored value no
real date has (NaN, infinite, past the year 5000) is left out instead of
trapping the conversion on every pop. A task without a date sends none, and
the server keeps or stamps its own.
GianniCarlo added a commit that referenced this pull request Oct 10, 2026
A progress push now carries the book's lastPlayDate, as the Android app's does
(bookplayer-android #130 and #132). The queued task already stored the date,
but the push never read it.

- Jellyfin gets LastPlayedDate. It stores a date only when a client sends one.
- AudiobookShelf gets lastUpdate, in epoch milliseconds. Without it, ABS
  records when the push landed. It honors ours when updating an existing
  entry; a book's first write still takes the server's clock.

The date is persisted with the task, like the position, so a stored value no
real date has (NaN, infinite, past the year 5000) is left out instead of
trapping the conversion on every pop. A task without a date sends none, and
the server keeps or stamps its own.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants