Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move the startup of the WebSocketWorker inside of run() #856

Merged
merged 1 commit into from
Feb 11, 2019
Merged

Move the startup of the WebSocketWorker inside of run() #856

merged 1 commit into from
Feb 11, 2019

Conversation

marci4
Copy link
Collaborator

@marci4 marci4 commented Feb 11, 2019

Description

Move the startup of the WebSocketWorker inside of the run() method

Related Issue

Fixes #855

Motivation and Context

Bug found in regression test

How Has This Been Tested?

Additional test

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@marci4
Fixes TooTallNate#855
d417e04 
Move the startup of the WebSocketWorker inside of the run() method
@marci4 marci4 added this to the Release 1.4.0 milestone Feb 11, 2019
@marci4 marci4 merged commit 6aa3b1f into TooTallNate:master Feb 11, 2019
@marci4 marci4 deleted the Issue855 branch February 11, 2019 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Bug Server
Projects
None yet
Milestone
Release 1.4.0
Development

Successfully merging this pull request may close these issues.

WebSocketServer cannot be started without .start()
1 participant
@marci4