Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WebSocketServer cannot be started without .start() #855

Closed
marci4 opened this issue Feb 11, 2019 · 0 comments · Fixed by #856
Closed

WebSocketServer cannot be started without .start() #855

marci4 opened this issue Feb 11, 2019 · 0 comments · Fixed by #856
Assignees
@marci4
Labels
Bug Server
Milestone
Release 1.4.0

Comments

@marci4
Copy link
Collaborator

marci4 commented Feb 11, 2019

Describe the bug
Before #850 you were able to start the server by using e.g. new Thread(websocketServer).start() and therefore not calling the native .start() method.
This does not work any more

To Reproduce
Steps to reproduce the behavior:

  1. Start server with new Thread(webSocketServer).start()
  2. Try to connect

Expected behavior
Connection is possible

Environment(please complete the following information):

  • Version used: 1.4.0-SNAPSHOT

Additional context
Found in the regressions test
@marci4 marci4 self-assigned this Feb 11, 2019
@marci4 marci4 added the Bug label Feb 11, 2019
@marci4 marci4 added this to the Release 1.4.0 milestone Feb 11, 2019
marci4 added a commit to marci4/Java-WebSocket-Dev that referenced this issue Feb 11, 2019
@marci4
Fixes TooTallNate#855
d417e04 
Move the startup of the WebSocketWorker inside of the run() method
@marci4 marci4 mentioned this issue Feb 11, 2019
Merged
8 tasks
@marci4 marci4 added the Server label Feb 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@marci4 marci4

Labels
Bug Server
Projects
None yet
Milestone
Release 1.4.0
Development

Successfully merging a pull request may close this issue.

Move the startup of the WebSocketWorker inside of run() marci4/Java-WebSocket-Dev
1 participant
@marci4