Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix some sonarqube errors #833

Merged
merged 1 commit into from
Jan 9, 2019
Merged

Fix some sonarqube errors #833

merged 1 commit into from
Jan 9, 2019

Conversation

marci4
Copy link
Collaborator

@marci4 marci4 commented Jan 2, 2019

Description

Fixed some sonarqube errors & added some tests for the websocket server

Related Issue

#749

Motivation and Context

Code quality

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@marci4
Fix some sonarqube errors
85a5d3d 
Fixed some sonarqube errors & added some tests for the websocket server
@marci4 marci4 added this to the Release 1.4.0 milestone Jan 2, 2019
@marci4 marci4 merged commit 4dbb2a3 into TooTallNate:master Jan 9, 2019
@marci4 marci4 deleted the SonarQubeFix branch January 9, 2019 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Refactor Test
Projects
None yet
Milestone
Release 1.4.0
Development

Successfully merging this pull request may close these issues.
1 participant
@marci4