Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve code quality for 1.4.0 #749

Closed
marci4 opened this issue Aug 6, 2018 · 3 comments
Closed

Improve code quality for 1.4.0 #749

marci4 opened this issue Aug 6, 2018 · 3 comments

Comments

@marci4
Copy link
Collaborator

marci4 commented Aug 6, 2018

Expected Behavior

SonarQube should not report to a lot of errors.

Current Behavior

Currently SonarQube reports some errors. These should be fixed!

Possible Solution

Fix errors found or disable rules!

Context

Code quality

@marci4 marci4 added this to the Release 1.3.10 milestone Aug 6, 2018
@PhilipRoman
Copy link
Collaborator

Glad to see I'm not the only one staring at SonarQube reports 😮! On a more serious note, I think the first thing to do should be splitting up the large methods into smaller ones. This is guaranteed not to break anything and it could even help to achieve better performance. Reading some of the code currently is quite hard and improving code quality may help more people contribute in the future.

Again, thanks for bringing this up!

@marci4
Copy link
Collaborator Author

marci4 commented Aug 6, 2018

Yeah we really have to do this!
Helps us and everyone checking all the methods.
Especially the WebSocketServer is a beauty in itself ;)

@marci4 marci4 added the Refactor label Aug 8, 2018
@marci4 marci4 modified the milestones: Release 1.3.10, Release 1.4.0 Sep 6, 2018
@marci4 marci4 mentioned this issue Nov 6, 2018
8 tasks
@marci4 marci4 mentioned this issue Jan 2, 2019
8 tasks
@marci4 marci4 changed the title Improve code quality Improve code quality for 1.4.0 Feb 17, 2019
@marci4
Copy link
Collaborator Author

marci4 commented Feb 17, 2019

We have a code close for 1.4.0.

Maybe opening another issue for 1.4.1.

Closing this issue as solved!

@marci4 marci4 closed this as completed Feb 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants