-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve code quality for 1.4.0 #749
Comments
Glad to see I'm not the only one staring at SonarQube reports 😮! On a more serious note, I think the first thing to do should be splitting up the large methods into smaller ones. This is guaranteed not to break anything and it could even help to achieve better performance. Reading some of the code currently is quite hard and improving code quality may help more people contribute in the future. Again, thanks for bringing this up! |
Yeah we really have to do this! |
We have a code close for 1.4.0. Maybe opening another issue for 1.4.1. Closing this issue as solved! |
Expected Behavior
SonarQube should not report to a lot of errors.
Current Behavior
Currently SonarQube reports some errors. These should be fixed!
Possible Solution
Fix errors found or disable rules!
Context
Code quality
The text was updated successfully, but these errors were encountered: