Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WebSocketServer code quality #789

Merged
merged 4 commits into from
Oct 23, 2018
Merged

WebSocketServer code quality #789

merged 4 commits into from
Oct 23, 2018

Conversation

marci4
Copy link
Collaborator

@marci4 marci4 commented Oct 21, 2018

Description

Refactoring as part of improving the code quality

Related Issue

Part of #749

Motivation and Context

Code quality helps fixing issues!

How Has This Been Tested?

All tests pass

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@marci4
Improve code quality
d9ec613 
Reduce complexity for WebSocketServer
@marci4
Additional tests
b26515b 
For WebSocketFactory and Compression Extension
@marci4 marci4 added this to the Release 1.4.0 milestone Oct 21, 2018
@marci4
Copy link
Collaborator Author

marci4 commented Oct 21, 2018

@PhilipRoman Conflict is not relevant FYI

@marci4 marci4 changed the title Web socket server code quality WebSocketServer code quality Oct 21, 2018
PhilipRoman
PhilipRoman approved these changes Oct 22, 2018
View reviewed changes
Copy link
Collaborator

@PhilipRoman PhilipRoman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow this is a lot easier to read now! 👍

PhilipRoman
PhilipRoman approved these changes Oct 22, 2018
View reviewed changes
Copy link
Collaborator

@PhilipRoman PhilipRoman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow this is a lot easier to read now! 👍

@PhilipRoman
Copy link
Collaborator

GitHub is not letting me "review" at the moment so I'm leaving this here. The changes are awesome! I didn't check all the tests but the ones I checked are good. 👍

1 similar comment
@PhilipRoman
Copy link
Collaborator

GitHub is not letting me "review" at the moment so I'm leaving this here. The changes are awesome! I didn't check all the tests but the ones I checked are good. 👍

PhilipRoman
PhilipRoman approved these changes Oct 22, 2018
View reviewed changes
Copy link
Collaborator

@PhilipRoman PhilipRoman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow this is a lot easier to read now! 👍

@PhilipRoman
Copy link
Collaborator

😆 I did not expect that to happen

@marci4 marci4 merged commit 797ab60 into TooTallNate:master Oct 23, 2018
@marci4 marci4 deleted the WebSocketServerCodeQuality branch October 24, 2018 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PhilipRoman PhilipRoman PhilipRoman approved these changes

Assignees
No one assigned
Labels
Refactor Test
Projects
None yet
Milestone
Release 1.4.0
Development

Successfully merging this pull request may close these issues.
2 participants
@marci4 @PhilipRoman