-
Notifications
You must be signed in to change notification settings - Fork 0
feat: add spacy model download and some logs! #26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThe changes include three main updates: the Dockerfile was modified to add a step that downloads the spaCy English language model ( Changes
Possibly related PRs
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
⏰ Context from checks skipped due to timeout of 90000ms (2)
🔇 Additional comments (1)
✨ Finishing Touches
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
Dockerfile (1)
5-5: Consider pinning the spaCy model version for reproducibility.The addition of the spaCy model download is correct and ensures the model is available at runtime. For more reproducible builds, consider specifying the model version explicitly (e.g.,
en_core_web_sm==3.7.1).
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
Dockerfile(1 hunks)hivemind_etl/mediawiki/etl.py(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (2)
- GitHub Check: ci / test / Test
- GitHub Check: ci / lint / Lint
🔇 Additional comments (1)
hivemind_etl/mediawiki/etl.py (1)
97-106: Logging additions improve observability.The new logging statements provide helpful runtime information and do not affect core logic. No issues found.
Summary by CodeRabbit
Chores
Enhancements