-
Notifications
You must be signed in to change notification settings - Fork 0
fix: wrong arg for MediaWikiETL! #22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThe changes update two functions in Changes
Sequence Diagram(s)sequenceDiagram
participant Caller
participant load_mediawiki_data
participant MediawikiETL
Caller->>load_mediawiki_data: Pass mediawiki_platform dict
load_mediawiki_data->>load_mediawiki_data: Extract namespaces from mediawiki_platform
load_mediawiki_data->>MediawikiETL: Pass community_id & namespaces to constructor
Possibly related PRs
Poem
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
hivemind_etl/mediawiki/activities.py(2 hunks)
🧰 Additional context used
🧬 Code Graph Analysis (1)
hivemind_etl/mediawiki/activities.py (1)
hivemind_etl/mediawiki/etl.py (1)
MediawikiETL(11-93)
⏰ Context from checks skipped due to timeout of 90000ms (2)
- GitHub Check: ci / test / Test
- GitHub Check: ci / lint / Lint
🔇 Additional comments (2)
hivemind_etl/mediawiki/activities.py (2)
75-77: Nice formatting improvement.The multi-line formatting for the function signature enhances readability while maintaining the same functionality. This is a good stylistic change that follows Python best practices for long function signatures.
98-98: Good addition of missing parameter extraction.Correctly extracting the
namespacesparameter from themediawiki_platformdictionary, consistent with how it's done in other functions likeextract_mediawikiandtransform_mediawiki_data.
Summary by CodeRabbit
Refactor
New Features