Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove dated comment about Natural Earth encoding #1288

Merged
merged 1 commit into from
Aug 17, 2023
Merged

Remove dated comment about Natural Earth encoding #1288

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions docs/manual.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -254,10 +254,9 @@ collection to get back to the beginning.
.. admonition:: File Encoding

The format drivers will attempt to detect the encoding of your data, but may
fail. In my experience GDAL 1.7.2 (for example) doesn't detect that the
encoding of the Natural Earth dataset is Windows-1252. In this case, the
proper encoding can be specified explicitly by using the ``encoding``
keyword parameter of :py:func:`fiona.open`: ``encoding='Windows-1252'``.
fail. In this case, the proper encoding can be specified explicitly by using
the ``encoding`` keyword parameter of :py:func:`fiona.open`, for example:
``encoding='Windows-1252'``.

New in version 0.9.1.

Expand Down
2 changes: 1 addition & 1 deletion fiona/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,7 @@ def open(

The drivers used by Fiona will try to detect the encoding of data
files. If they fail, you may provide the proper ``encoding``, such
as 'Windows-1252' for the Natural Earth datasets.
as 'Windows-1252' for the original Natural Earth datasets.

When the provided path is to a file containing multiple named layers
of data, a layer can be singled out by ``layer``.
Expand Down