Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove dated comment about Natural Earth encoding #1288

Merged
merged 1 commit into from
Aug 17, 2023
Merged

Remove dated comment about Natural Earth encoding #1288

merged 1 commit into from
Aug 17, 2023

Conversation

lgolston
Copy link
Contributor

There are two references to the Natural Earth datasets having Windows-1252 encoding, which are removed here since those transitioned to UTF-8 some years ago.

mwtoews
mwtoews approved these changes Aug 17, 2023
View reviewed changes
Copy link
Member

@mwtoews mwtoews left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Backported to maint-1.9 with f0deb38

@mwtoews mwtoews merged commit 3434e2d into Toblerity:master Aug 17, 2023
8 checks passed
mwtoews pushed a commit that referenced this pull request Aug 17, 2023
@lgolston @mwtoews
update encoding warning (#1288)
f0deb38
@lgolston lgolston deleted the manual-note branch August 18, 2023 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mwtoews mwtoews mwtoews approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lgolston @mwtoews