-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Testing all our services, directives, and components #337
Comments
This is an excellent idea - I would recommend this is done one by one instead of all at once. A good example of a component that is tested by a number of modules is the date selection (too far in the future/ past validation). The Session and Login services are used on every application load - these would also be priorities for test coverage. |
Someone should make a list of the components/directives that need unit tests. We could tackle them one by one that way. |
So, I did some analysis this weekend, and these are the directives/components that could use some unit tests written for them:
Any of these can be tackled and worked on at any time. Since Travis now runs our unit tests (see #357), these tests will have a lot more value. If someone implements a test, they should reference this issue. |
3550: Update snyk to the latest version 🚀 r=jniles a=greenkeeper[bot] ## The dependency [snyk](https://github.com/snyk/snyk) was updated from `1.122.1` to `1.122.3`. This version is **not covered** by your **current version range**. If you don’t accept this pull request, your project will work just like it did before. However, you might be missing out on a bunch of new features, fixes and/or performance improvements from the dependency update. --- <details> <summary>Release Notes for v1.122.3</summary> <h2><a href="https://urls.greenkeeper.io/snyk/snyk/compare/v1.122.2...v1.122.3">1.122.3</a> (2019-01-21)</h2> <h3>Bug Fixes</h3> <ul> <li>bump php plugin to better support file paths (<a href="https://urls.greenkeeper.io/snyk/snyk/commit/319cf35">319cf35</a>)</li> </ul> </details> <details> <summary>Commits</summary> <p>The new version differs by 6 commits.</p> <ul> <li><a href="https://urls.greenkeeper.io/snyk/snyk/commit/6b07600cf7d935bb9a022fba1a8c8486db051878"><code>6b07600</code></a> <code>Merge pull request #337 from snyk/fix/php-plugin-bump</code></li> <li><a href="https://urls.greenkeeper.io/snyk/snyk/commit/319cf35833b4bb24e6070cdec611280dd8c602e9"><code>319cf35</code></a> <code>fix: bump php plugin to better support file paths</code></li> <li><a href="https://urls.greenkeeper.io/snyk/snyk/commit/f773c773e44deac8655006f19bafe9e4825fb6d7"><code>f773c77</code></a> <code>Merge pull request #338 from snyk/fix/bump-docker-plugin</code></li> <li><a href="https://urls.greenkeeper.io/snyk/snyk/commit/b4ba234106ac0f0bf37ea9408071c95b12dd5d63"><code>b4ba234</code></a> <code>Merge pull request #341 from snyk/test/revert-a-fixture-change</code></li> <li><a href="https://urls.greenkeeper.io/snyk/snyk/commit/bbfd7002aed081b4c4018c4f2743a11329c93f9a"><code>bbfd700</code></a> <code>test: remove a fixture change done in <a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="401225818" data-permission-text="Issue title is private" data-url="snyk/cli#340" data-hovercard-type="pull_request" data-hovercard-url="/snyk/cli/pull/340/hovercard" href="https://urls.greenkeeper.io/snyk/snyk/pull/340">#340</a></code></li> <li><a href="https://urls.greenkeeper.io/snyk/snyk/commit/3667dcdc5b074f04d4ba5184a9293a0e97691bd2"><code>3667dcd</code></a> <code>fix: bump docker plugin</code></li> </ul> <p>See the <a href="https://urls.greenkeeper.io/snyk/snyk/compare/567e3b31d8dd3a67755ed726e0da21efcad91ba8...6b07600cf7d935bb9a022fba1a8c8486db051878">full diff</a></p> </details> <details> <summary>FAQ and help</summary> There is a collection of [frequently asked questions](https://greenkeeper.io/faq.html). If those don’t help, you can always [ask the humans behind Greenkeeper](https://github.com/greenkeeperio/greenkeeper/issues/new). </details> --- Your [Greenkeeper](https://greenkeeper.io) bot 🌴 Co-authored-by: greenkeeper[bot] <greenkeeper[bot]@users.noreply.github.com>
3550: Update snyk to the latest version 🚀 r=jniles a=greenkeeper[bot] ## The dependency [snyk](https://github.com/snyk/snyk) was updated from `1.122.1` to `1.122.3`. This version is **not covered** by your **current version range**. If you don’t accept this pull request, your project will work just like it did before. However, you might be missing out on a bunch of new features, fixes and/or performance improvements from the dependency update. --- <details> <summary>Release Notes for v1.122.3</summary> <h2><a href="https://urls.greenkeeper.io/snyk/snyk/compare/v1.122.2...v1.122.3">1.122.3</a> (2019-01-21)</h2> <h3>Bug Fixes</h3> <ul> <li>bump php plugin to better support file paths (<a href="https://urls.greenkeeper.io/snyk/snyk/commit/319cf35">319cf35</a>)</li> </ul> </details> <details> <summary>Commits</summary> <p>The new version differs by 6 commits.</p> <ul> <li><a href="https://urls.greenkeeper.io/snyk/snyk/commit/6b07600cf7d935bb9a022fba1a8c8486db051878"><code>6b07600</code></a> <code>Merge pull request #337 from snyk/fix/php-plugin-bump</code></li> <li><a href="https://urls.greenkeeper.io/snyk/snyk/commit/319cf35833b4bb24e6070cdec611280dd8c602e9"><code>319cf35</code></a> <code>fix: bump php plugin to better support file paths</code></li> <li><a href="https://urls.greenkeeper.io/snyk/snyk/commit/f773c773e44deac8655006f19bafe9e4825fb6d7"><code>f773c77</code></a> <code>Merge pull request #338 from snyk/fix/bump-docker-plugin</code></li> <li><a href="https://urls.greenkeeper.io/snyk/snyk/commit/b4ba234106ac0f0bf37ea9408071c95b12dd5d63"><code>b4ba234</code></a> <code>Merge pull request #341 from snyk/test/revert-a-fixture-change</code></li> <li><a href="https://urls.greenkeeper.io/snyk/snyk/commit/bbfd7002aed081b4c4018c4f2743a11329c93f9a"><code>bbfd700</code></a> <code>test: remove a fixture change done in <a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="401225818" data-permission-text="Issue title is private" data-url="snyk/cli#340" data-hovercard-type="pull_request" data-hovercard-url="/snyk/cli/pull/340/hovercard" href="https://urls.greenkeeper.io/snyk/snyk/pull/340">#340</a></code></li> <li><a href="https://urls.greenkeeper.io/snyk/snyk/commit/3667dcdc5b074f04d4ba5184a9293a0e97691bd2"><code>3667dcd</code></a> <code>fix: bump docker plugin</code></li> </ul> <p>See the <a href="https://urls.greenkeeper.io/snyk/snyk/compare/567e3b31d8dd3a67755ed726e0da21efcad91ba8...6b07600cf7d935bb9a022fba1a8c8486db051878">full diff</a></p> </details> <details> <summary>FAQ and help</summary> There is a collection of [frequently asked questions](https://greenkeeper.io/faq.html). If those don’t help, you can always [ask the humans behind Greenkeeper](https://github.com/greenkeeperio/greenkeeper/issues/new). </details> --- Your [Greenkeeper](https://greenkeeper.io) bot 🌴 Co-authored-by: greenkeeper[bot] <greenkeeper[bot]@users.noreply.github.com>
Our services, directives and components have not a unit test yet, I propose to begin writting test for each service and directive one by one.
So our end to end test will be more simple because we will not try to test component during the end to end test, but we will just use them.
What do you think?
The text was updated successfully, but these errors were encountered: