-
Notifications
You must be signed in to change notification settings - Fork 557
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: pin proxy-agent & get-uri deps to not-break node 4 #340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
as `proxy-agent` -> `pac-proxy-agent` -> `get-uri@^2.0.0` and in `get-uri@2.0.3`, the `debug` dep was bumped from 2 to 4 (TooTallNate/node-get-uri@126d4f5) and this doesn't support node 4 (throwing `SyntaxError`) note this commit adds `get-uri` as a direct dep, although it isn't
michael-go
force-pushed
the
fix/pin-deps-to-unbreak-node-4
branch
from
January 21, 2019 07:31
a39cbd5
to
8bfae15
Compare
adrukh
approved these changes
Jan 21, 2019
michael-go
force-pushed
the
fix/pin-deps-to-unbreak-node-4
branch
from
January 21, 2019 09:29
73685aa
to
c7966f8
Compare
michael-go
added a commit
that referenced
this pull request
Jan 21, 2019
michael-go
added a commit
that referenced
this pull request
Jan 21, 2019
test: remove a fixture change done in PR #340
bors bot
added a commit
to Third-Culture-Software/bhima
that referenced
this pull request
Jan 21, 2019
3550: Update snyk to the latest version 🚀 r=jniles a=greenkeeper[bot] ## The dependency [snyk](https://github.com/snyk/snyk) was updated from `1.122.1` to `1.122.3`. This version is **not covered** by your **current version range**. If you don’t accept this pull request, your project will work just like it did before. However, you might be missing out on a bunch of new features, fixes and/or performance improvements from the dependency update. --- <details> <summary>Release Notes for v1.122.3</summary> <h2><a href="https://urls.greenkeeper.io/snyk/snyk/compare/v1.122.2...v1.122.3">1.122.3</a> (2019-01-21)</h2> <h3>Bug Fixes</h3> <ul> <li>bump php plugin to better support file paths (<a href="https://urls.greenkeeper.io/snyk/snyk/commit/319cf35">319cf35</a>)</li> </ul> </details> <details> <summary>Commits</summary> <p>The new version differs by 6 commits.</p> <ul> <li><a href="https://urls.greenkeeper.io/snyk/snyk/commit/6b07600cf7d935bb9a022fba1a8c8486db051878"><code>6b07600</code></a> <code>Merge pull request #337 from snyk/fix/php-plugin-bump</code></li> <li><a href="https://urls.greenkeeper.io/snyk/snyk/commit/319cf35833b4bb24e6070cdec611280dd8c602e9"><code>319cf35</code></a> <code>fix: bump php plugin to better support file paths</code></li> <li><a href="https://urls.greenkeeper.io/snyk/snyk/commit/f773c773e44deac8655006f19bafe9e4825fb6d7"><code>f773c77</code></a> <code>Merge pull request #338 from snyk/fix/bump-docker-plugin</code></li> <li><a href="https://urls.greenkeeper.io/snyk/snyk/commit/b4ba234106ac0f0bf37ea9408071c95b12dd5d63"><code>b4ba234</code></a> <code>Merge pull request #341 from snyk/test/revert-a-fixture-change</code></li> <li><a href="https://urls.greenkeeper.io/snyk/snyk/commit/bbfd7002aed081b4c4018c4f2743a11329c93f9a"><code>bbfd700</code></a> <code>test: remove a fixture change done in <a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="401225818" data-permission-text="Issue title is private" data-url="snyk/cli#340" data-hovercard-type="pull_request" data-hovercard-url="/snyk/cli/pull/340/hovercard" href="https://urls.greenkeeper.io/snyk/snyk/pull/340">#340</a></code></li> <li><a href="https://urls.greenkeeper.io/snyk/snyk/commit/3667dcdc5b074f04d4ba5184a9293a0e97691bd2"><code>3667dcd</code></a> <code>fix: bump docker plugin</code></li> </ul> <p>See the <a href="https://urls.greenkeeper.io/snyk/snyk/compare/567e3b31d8dd3a67755ed726e0da21efcad91ba8...6b07600cf7d935bb9a022fba1a8c8486db051878">full diff</a></p> </details> <details> <summary>FAQ and help</summary> There is a collection of [frequently asked questions](https://greenkeeper.io/faq.html). If those don’t help, you can always [ask the humans behind Greenkeeper](https://github.com/greenkeeperio/greenkeeper/issues/new). </details> --- Your [Greenkeeper](https://greenkeeper.io) bot 🌴 Co-authored-by: greenkeeper[bot] <greenkeeper[bot]@users.noreply.github.com>
bors bot
added a commit
to Third-Culture-Software/bhima
that referenced
this pull request
Jan 21, 2019
3550: Update snyk to the latest version 🚀 r=jniles a=greenkeeper[bot] ## The dependency [snyk](https://github.com/snyk/snyk) was updated from `1.122.1` to `1.122.3`. This version is **not covered** by your **current version range**. If you don’t accept this pull request, your project will work just like it did before. However, you might be missing out on a bunch of new features, fixes and/or performance improvements from the dependency update. --- <details> <summary>Release Notes for v1.122.3</summary> <h2><a href="https://urls.greenkeeper.io/snyk/snyk/compare/v1.122.2...v1.122.3">1.122.3</a> (2019-01-21)</h2> <h3>Bug Fixes</h3> <ul> <li>bump php plugin to better support file paths (<a href="https://urls.greenkeeper.io/snyk/snyk/commit/319cf35">319cf35</a>)</li> </ul> </details> <details> <summary>Commits</summary> <p>The new version differs by 6 commits.</p> <ul> <li><a href="https://urls.greenkeeper.io/snyk/snyk/commit/6b07600cf7d935bb9a022fba1a8c8486db051878"><code>6b07600</code></a> <code>Merge pull request #337 from snyk/fix/php-plugin-bump</code></li> <li><a href="https://urls.greenkeeper.io/snyk/snyk/commit/319cf35833b4bb24e6070cdec611280dd8c602e9"><code>319cf35</code></a> <code>fix: bump php plugin to better support file paths</code></li> <li><a href="https://urls.greenkeeper.io/snyk/snyk/commit/f773c773e44deac8655006f19bafe9e4825fb6d7"><code>f773c77</code></a> <code>Merge pull request #338 from snyk/fix/bump-docker-plugin</code></li> <li><a href="https://urls.greenkeeper.io/snyk/snyk/commit/b4ba234106ac0f0bf37ea9408071c95b12dd5d63"><code>b4ba234</code></a> <code>Merge pull request #341 from snyk/test/revert-a-fixture-change</code></li> <li><a href="https://urls.greenkeeper.io/snyk/snyk/commit/bbfd7002aed081b4c4018c4f2743a11329c93f9a"><code>bbfd700</code></a> <code>test: remove a fixture change done in <a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="401225818" data-permission-text="Issue title is private" data-url="snyk/cli#340" data-hovercard-type="pull_request" data-hovercard-url="/snyk/cli/pull/340/hovercard" href="https://urls.greenkeeper.io/snyk/snyk/pull/340">#340</a></code></li> <li><a href="https://urls.greenkeeper.io/snyk/snyk/commit/3667dcdc5b074f04d4ba5184a9293a0e97691bd2"><code>3667dcd</code></a> <code>fix: bump docker plugin</code></li> </ul> <p>See the <a href="https://urls.greenkeeper.io/snyk/snyk/compare/567e3b31d8dd3a67755ed726e0da21efcad91ba8...6b07600cf7d935bb9a022fba1a8c8486db051878">full diff</a></p> </details> <details> <summary>FAQ and help</summary> There is a collection of [frequently asked questions](https://greenkeeper.io/faq.html). If those don’t help, you can always [ask the humans behind Greenkeeper](https://github.com/greenkeeperio/greenkeeper/issues/new). </details> --- Your [Greenkeeper](https://greenkeeper.io) bot 🌴 Co-authored-by: greenkeeper[bot] <greenkeeper[bot]@users.noreply.github.com>
This was referenced Jan 13, 2020
This was referenced Jul 9, 2020
This was referenced Mar 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as
proxy-agent
->pac-proxy-agent
->get-uri@^2.0.0
and in
get-uri@2.0.3
, thedebug
dep was bumped from 2 to 4(TooTallNate/node-get-uri@126d4f5)
and this doesn't support node 4 (throwing
SyntaxError
)note this commit adds
get-uri
as a direct dep, although it isn't