Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Inflate_all() #204

Merged
merged 43 commits into from
Jun 8, 2023
Merged

feat: Inflate_all() #204

merged 43 commits into from
Jun 8, 2023

Commits on Apr 20, 2023

  1. feat: Inflate_all() 

    tags: feat, wip

Why?

- The inflate_all() function is tested

What?

- We need to finalize the documentation and split the current flat file into two flat files

Issues

issue #96
    @ymansiaux
    ymansiaux committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    e72790d View commit details
    Browse the repository at this point in the history

  2. doc: Splitted inflate_all into 2 flat files 

    tags: doc

Why?

-

What?

-

Issues

issue #96
    @ymansiaux
    ymansiaux committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    20e7123 View commit details
    Browse the repository at this point in the history

  3. doc: Updated inflate_all doc 

    tags: doc

Why?

-

What?

-

Issues

issue #96
    @ymansiaux
    ymansiaux committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    bbab20d View commit details
    Browse the repository at this point in the history

  4. fix: Remove adding "pkg" in config_fusen.yml 

    tags: fix

Why?

-

What?

-

Issues

issue #96
    @ymansiaux
    ymansiaux committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    c38ecfc View commit details
    Browse the repository at this point in the history

  5. fix: Edited df_to_config() 

    tags: fix, test

Why?

- df_to_config() shouldnt be allowed to receive inflate parameters when working with "keep"

What?

- Edited the function, doc, and unit tests

Issues

issue #96
    @ymansiaux
    ymansiaux committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    9bf63cb View commit details
    Browse the repository at this point in the history

Commits on Apr 28, 2023

  1. feat: add params to warnings 

    tags: feat, test

Why?

warnings comes with the call of the function it was called, here it was not really informative

What?

- Add call. = FALSE to clean the warning output
    @statnmap
    statnmap committed Apr 28, 2023
    Configuration menu
    Copy the full SHA
    2ae7e7b View commit details
    Browse the repository at this point in the history

  2. feat: add params in stop() 

    tags: feat, doc, test

Why?

- Stop also outputs the call by default

What?

- Clean stop call output to avoid do.call(xxx) message
    @statnmap
    statnmap committed Apr 28, 2023
    Configuration menu
    Copy the full SHA
    f397a1b View commit details
    Browse the repository at this point in the history

  3. fix: return nothing if cancel addin 

    tags: fix

Stop the process if Cancel is checked

issue #157
    @statnmap
    statnmap committed Apr 28, 2023
    Configuration menu
    Copy the full SHA
    bb9b8c3 View commit details
    Browse the repository at this point in the history

  4. feat: wip - clear message and check out 

    tags: feat, test
    @statnmap
    statnmap committed Apr 28, 2023
    Configuration menu
    Copy the full SHA
    a3e71e9 View commit details
    Browse the repository at this point in the history

  5. fix: modify tests according to new messages 

    tags: fix, test

Why?

- Showing messages with {cli} for clarity

What?

- Update unit test
- Add function to be tested for outputs only
- Refactor unit test structure with multiple test_that calls for easier maintenance
    @statnmap
    statnmap committed Apr 28, 2023
    Configuration menu
    Copy the full SHA
    56bc321 View commit details
    Browse the repository at this point in the history

  6. feat: add check and document in inflate all 

    tags: feat

Why?

- Need to document and check once only

What?

- Add check an document as in inflate
    @statnmap
    statnmap committed Apr 28, 2023
    Configuration menu
    Copy the full SHA
    a7f569e View commit details
    Browse the repository at this point in the history

Commits on Apr 29, 2023

  1. refactor: clean warnings and messages 

    tags: refactor, test

Why?

- Unit tests output is long and multiple messages are useless for debugging
- New version of R does not like to readlines with missing final line

What?

- Added some suppressMessages()
- Added extra line in `cat()` created files
    @statnmap
    statnmap committed Apr 29, 2023
    Configuration menu
    Copy the full SHA
    5bb9dec View commit details
    Browse the repository at this point in the history

Commits on May 5, 2023

  1. fix: Correcting unit tests for inflate_all() 

    tags: fix, test

Why?

-

What?

- qpdf had to be installed on workbench
- replaced some expect_equal by expect_true(all(...))

Issues

issue #96
    @ymansiaux
    ymansiaux committed May 5, 2023
    Configuration menu
    Copy the full SHA
    0bd4b70 View commit details
    Browse the repository at this point in the history

Commits on May 9, 2023

  1. ci: Added MASS in dependencies 

    tags: ci

Why?

- Trying to resolve CI errors

What?

-

Issues

issue #96
    @ymansiaux
    ymansiaux committed May 9, 2023
    Configuration menu
    Copy the full SHA
    9ae6670 View commit details
    Browse the repository at this point in the history

  2. ci: Added {lattice} 

    tags: ci

Why?

-

What?

-

Issues

issue #96
    @ymansiaux
    ymansiaux committed May 9, 2023
    Configuration menu
    Copy the full SHA
    4a2cc1c View commit details
    Browse the repository at this point in the history

  3. ci: Added {Matrix} 

    tags: ci

Why?

-

What?

-

Issues

issue #96
    @ymansiaux
    ymansiaux committed May 9, 2023
    Configuration menu
    Copy the full SHA
    c6b5d76 View commit details
    Browse the repository at this point in the history

Commits on May 10, 2023

  1. ci: Added nlme 

    tags: ci

Why?

-

What?

-

Issues

issue #96
    @ymansiaux
    ymansiaux committed May 10, 2023
    Configuration menu
    Copy the full SHA
    28deeb9 View commit details
    Browse the repository at this point in the history

  2. fix: Changing devtools::check with rcmdcheck::rcmdcheck 

    tags: fix, feat, test, ci

Why?

- We had issues using devtools::check because of a missing MASS library

What?

- check() automatically builds a package before calling check_built(), as this is the recommended way to check packages. Note that this process runs in an independent R session, so nothing in your current workspace will affect the process. Under-the-hood, check() and check_built() rely on pkgbuild::build() and rcmdcheck::rcmdcheck().

Issues

issue #96
    @ymansiaux
    ymansiaux committed May 10, 2023
    Configuration menu
    Copy the full SHA
    0ceda0a View commit details
    Browse the repository at this point in the history

  3. test: Added unit tests to deal with "keep" in inflate_all() 

    tags: test

Why?

-

What?

-

Issues

issue #96
    @ymansiaux
    ymansiaux committed May 10, 2023
    Configuration menu
    Copy the full SHA
    31f08a1 View commit details
    Browse the repository at this point in the history

  4. fix: Removed a forgotten browser() 

    tags: fix

Why?

-

What?

-

Issues

issue #96
    @ymansiaux
    ymansiaux committed May 10, 2023
    Configuration menu
    Copy the full SHA
    8e4901d View commit details
    Browse the repository at this point in the history

  5. test: Add test for inflate_all_no_check() 

    tags: test

Why?

-

What?

-

Issues

issue #96
    @ymansiaux
    ymansiaux committed May 10, 2023
    Configuration menu
    Copy the full SHA
    a39a1a5 View commit details
    Browse the repository at this point in the history

Commits on May 11, 2023

  1. feat: Stored logicals in yaml in the right format 

    tags: feat

Why?

-  Logicals were written as yes/no, we want them to be stored as TRUE/FALSE

What?

- https://tech.lgbt/@debruine/110315357001043525

Issues

issue #96
    @ymansiaux
    ymansiaux committed May 11, 2023
    Configuration menu
    Copy the full SHA
    a253b4e View commit details
    Browse the repository at this point in the history

  2. feat: Add a function to document and check package 

    tags: feat

Why?

- The same operation was done in inflate() and inflate_all(), we needed a function

What?

- see document_and_check_pkg()

Issues

issue #96
    @ymansiaux
    ymansiaux committed May 11, 2023
    Configuration menu
    Copy the full SHA
    ba45a5a View commit details
    Browse the repository at this point in the history

Commits on May 26, 2023

  1. feat: Switched rcmdcheck::rcmdcheck with devtools::check 

    tags: feat, test

Why?

- According to @statnmap message on 2023/05/11 (#204) we decided to revert the use of rcmdcheck.

What?

- inflate_all(check = TRUE) are now only tested in interactive mode

Issues

issue #96
    @ymansiaux
    ymansiaux committed May 26, 2023
    Configuration menu
    Copy the full SHA
    1982567 View commit details
    Browse the repository at this point in the history

  2. fix: Use check=FALSE in inflate_all() examples 

    tags: fix, doc, ci

Why?

-

What?

-

Issues

issue #96
    @ymansiaux
    ymansiaux committed May 26, 2023
    Configuration menu
    Copy the full SHA
    41eafde View commit details
    Browse the repository at this point in the history

Commits on Jun 3, 2023

  1. chore: upgrade actions devel 

    tags: chore, ci

- Use the latest version of actions to apply to 'devel' action (the one that use the github version of parsermd)
- Use ubuntu-devel
    @statnmap
    statnmap committed Jun 3, 2023
    Configuration menu
    Copy the full SHA
    1d42b12 View commit details
    Browse the repository at this point in the history

  2. ci: fix devel action

    @statnmap
    statnmap committed Jun 3, 2023
    Configuration menu
    Copy the full SHA
    c0020e6 View commit details
    Browse the repository at this point in the history

Commits on Jun 4, 2023

  1. fix: warning No such file or directory 

    tags: fix, test

path_foosen does not exist till it is not created. normalizePath need mustWork=FALSE to avoid sending a warning.
    @statnmap
    statnmap committed Jun 4, 2023
    Configuration menu
    Copy the full SHA
    37c6acd View commit details
    Browse the repository at this point in the history

  2. fix: incomplete final line on Rproj 

    tags: fix, test

- Add extra line in Rproj file.
    @statnmap
    statnmap committed Jun 4, 2023
    Configuration menu
    Copy the full SHA
    5982ec4 View commit details
    Browse the repository at this point in the history

  3. fix: do not deal with attachment warning 

    tags: fix, test

- It was anticipated a problem with new version of attachment, but it is finally not the case. We can verify it as it is now on CRAN
    @statnmap
    statnmap committed Jun 4, 2023
    Configuration menu
    Copy the full SHA
    5af02ac View commit details
    Browse the repository at this point in the history

  4. chore: refactor NEWS file

    @statnmap
    statnmap committed Jun 4, 2023
    Configuration menu
    Copy the full SHA
    f2049bc View commit details
    Browse the repository at this point in the history

  5. refactor: separate config from clean doc 

    tags: refactor, test, doc

- As clean phase is not ready, we keep it separated for later developments
    @statnmap
    statnmap committed Jun 4, 2023
    Configuration menu
    Copy the full SHA
    312c75d View commit details
    Browse the repository at this point in the history

  6. fix: make the force be with us 

    tags: fix, test

- `force` parameter should allow to add files in the config file even if they do not exist
    @statnmap
    statnmap committed Jun 4, 2023
    Configuration menu
    Copy the full SHA
    84b23dd View commit details
    Browse the repository at this point in the history

  7. chore: style package with styler

    @statnmap
    statnmap committed Jun 4, 2023
    Configuration menu
    Copy the full SHA
    fd4bc56 View commit details
    Browse the repository at this point in the history

  8. doc: update documentation for inflate_all 

    tags: doc

- Manage NEWS with unpublished 0.5.0
- Re-write inflate_all doc
    @statnmap
    statnmap committed Jun 4, 2023
    Configuration menu
    Copy the full SHA
    7360e50 View commit details
    Browse the repository at this point in the history

Commits on Jun 6, 2023

  1. fix: Use names instead of position 

    tags: fix, test

- Modification of files needs to be done using name instead of position as 'sort' changes in non-interactive environments
- Fix 'sort' by 'order' in unit tests to properly select a row

issue #96
    @statnmap
    statnmap committed Jun 6, 2023
    Configuration menu
    Copy the full SHA
    845ff24 View commit details
    Browse the repository at this point in the history

  2. chore: update contributing

    @statnmap
    statnmap committed Jun 6, 2023
    Configuration menu
    Copy the full SHA
    679d051 View commit details
    Browse the repository at this point in the history

  3. chore: update inflates to inflate_all 

    tags: chore

- Need to inflate a few flats before being able to use inflate_all()
- Or define state
    @statnmap
    statnmap committed Jun 6, 2023
    Configuration menu
    Copy the full SHA
    cf76ea9 View commit details
    Browse the repository at this point in the history

  4. fix: inflate_all with no state in keep section 

    tags: fix, test

- A dev version of fusen has no "state" in "keep" section

issue #96
    @statnmap
    statnmap committed Jun 6, 2023
    Configuration menu
    Copy the full SHA
    e9d0b40 View commit details
    Browse the repository at this point in the history

  5. feat: inflate_all does not open any vignette by default 

    tags: feat, doc

- Opening a vignette is an individual choice

issue #96
    @statnmap
    statnmap committed Jun 6, 2023
    Configuration menu
    Copy the full SHA
    dbb617c View commit details
    Browse the repository at this point in the history

  6. fix: set back check outputs with print() 

    tags: fix

- check() outputs need to be printed in the console
    @statnmap
    statnmap committed Jun 6, 2023
    Configuration menu
    Copy the full SHA
    e8bc3f9 View commit details
    Browse the repository at this point in the history

  7. feat: make inflate output invisible 

    tags: feat

There is no general use to see the path of the current package being inflated. It only matters for unit tests
    @statnmap
    statnmap committed Jun 6, 2023
    Configuration menu
    Copy the full SHA
    7457d2c View commit details
    Browse the repository at this point in the history

  8. doc: update with no_check()

    @statnmap
    statnmap committed Jun 6, 2023
    Configuration menu
    Copy the full SHA
    212e785 View commit details
    Browse the repository at this point in the history