Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: Cancel "Add {fusen} chunk" #157

Closed
MurielleDelmotte opened this issue Jun 24, 2022 · 1 comment · Fixed by #204
Closed

bug: Cancel "Add {fusen} chunk" #157

MurielleDelmotte opened this issue Jun 24, 2022 · 1 comment · Fixed by #204
Assignees
@statnmap
Milestone
v0.5 - Please cle...

Comments

@MurielleDelmotte
Copy link

When you click on Cancel, it doesn't close the modalDialog.

image

Finally, it inserts an empty function description
image
@FlorenceMounier
Copy link
Contributor

Proposal:
add a default name for the new function, like in "Add {fusen} flat template => see code example there ~/fusen/R/addins.R

@FlorenceMounier FlorenceMounier self-assigned this Nov 18, 2022
statnmap added a commit that referenced this issue Apr 28, 2023
@statnmap
fix: return nothing if cancel addin
bb9b8c3 
tags: fix

Stop the process if Cancel is checked

issue #157
@statnmap statnmap assigned statnmap and unassigned FlorenceMounier Apr 28, 2023
@statnmap statnmap mentioned this issue Jun 2, 2023
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@statnmap statnmap

Labels
None yet
Projects
None yet
Milestone
v0.5 - Please clean up your mess!
Development

Successfully merging a pull request may close this issue.

feat: Inflate_all() ThinkR-open/fusen
3 participants
@statnmap @MurielleDelmotte @FlorenceMounier