Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial set of changes to make urls work #9

Merged
merged 7 commits into from
Apr 8, 2015
Merged

Initial set of changes to make urls work #9

merged 7 commits into from
Apr 8, 2015

Conversation

johanneslumpe
Copy link
Contributor

Ok this is very much a work in progress. URL-loading works now, but I might have broken playing of local files. Or it might be an issue with my project not recognizing the local file.

I assume this PR will still change quite a bit, but it's a start :)

@johanneslumpe
Copy link
Contributor Author

I think we should move the progress update timer creating and of course invalidation into setSrc

@qingfeng
Copy link
Contributor

qingfeng commented Apr 8, 2015

🍺

@brianchirls
Copy link

Good progress. What happens if the source is changed?

Again, I suggest changing onProgress to onTimeupdate (or onTimeUpdate) so progress can be used for notifications of partial buffering updates. See here for an idea on how to implement that, by the way. Refer to my note in #8. Thanks.

@johanneslumpe
Copy link
Contributor Author

@brianchirls Right now, if you change the source, the old player will be discarded and the new source will be loaded and will start playing as soon as it becomes ready to play.

Your note in #8 refers to being able to change the file type - that can be done now, by setting the type property of the src object. But you mentioned checking for a file extension. That might also be a nice way to just automatically detect it. I'd propose that we do both. If type is not set - fall back to extension scanning. If type is set, use the passed in type, regardless of the file's actual extension.

@brianchirls
Copy link

Discarding the old player sounds good.

Oops, sorry. I meant my notes in #7 (comment)

@brentvatne
Copy link
Contributor

@brianchirls

Again, I suggest changing onProgress to onTimeupdate (or onTimeUpdate) so progress can be used for notifications of partial buffering updates. See here for an idea on how to implement that, by the way. Refer to my note in #8. Thanks.

onTimeUpdate is a good idea, in the interest of not making this such a big diff I'll open another issue for that

@brentvatne
Copy link
Contributor

Added an example project to test it out, all working great! Thanks!

brentvatne added a commit that referenced this pull request Apr 8, 2015
…port

Refactor events, add support for filetype and uri parameters to source, add example project
@brentvatne brentvatne merged commit b689238 into TheWidlarzGroup:master Apr 8, 2015
@Hamiltontx Hamiltontx mentioned this pull request Jun 20, 2016
hueniverse pushed a commit that referenced this pull request Jun 9, 2022
Add support for L1 to L3 Widevine fallback if playback fails initially.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants