Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load videos remotely from the network #8

Merged
merged 1 commit into from
Apr 7, 2015

Conversation

qingfeng
Copy link
Contributor

@qingfeng qingfeng commented Apr 7, 2015

pls, review. thanks

@brentvatne
Copy link
Contributor

@qingfeng - This is a good step forward, ultimately I would like to move towards supporting the same syntax as Image by having the source prop be an object with the uri param. This would work well with adding an onLoadStart callback too, so we could show some kind of loading indicator.

One nit and I'll merge - could you change indentations to two spaces instead of tabs?

Thanks! 😄

@brianchirls
Copy link

Yes, good start. I think we'd need to scan for file extensions as well for local files. It may not always be mp4.

@qingfeng
Copy link
Contributor Author

qingfeng commented Apr 7, 2015

sorry, I modified the two space

brentvatne added a commit that referenced this pull request Apr 7, 2015
Load videos remotely from the network
@brentvatne brentvatne merged commit d3e8820 into TheWidlarzGroup:master Apr 7, 2015
@brentvatne
Copy link
Contributor

Thanks 😸

@qingfeng qingfeng deleted the up branch April 7, 2015 19:51
@qingfeng
Copy link
Contributor Author

qingfeng commented Apr 7, 2015

🍺

@qingfeng qingfeng restored the up branch April 7, 2015 20:12
hueniverse pushed a commit that referenced this pull request Jun 9, 2022
Add support for detecting if format is supported and exclude unsupported resolutions from auto quality selection and video track info in RN.
yungblud added a commit to react-native-yeouido/react-native-video that referenced this pull request May 10, 2023
…build-gradle

build gradle 관련 리팩토링
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants