Add media session support on android #3604
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add supports for media sessions on android
Mostly followed the android guide and what was done in #3080 (mostly for props handling).
Motivation
Support hardware play/pause buttons on headsets and tv's remotes.
Changes
Add
mediaSessionprops where one can specify title, description...Test plan
I'd like to ask about how to proceed for this actually, this is my first contribution to native react code, should I just use this PR in a project and build an expo-dev client to test that? Is there something easier?
I did not test this yet, it may not even compile yet. I really just put it here to get feedback on how to debug/run/compile this.