Add support for Android Media Session #3080
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This Pr looks good thank you. but unfortunately, I didn't plan to make evolution on 5.2 branch. |
|
@freeboub I avoided using the master branch as we haven't moved over to v6 while it's in alpha. If that gets a stable release within the next few months then I'm happy to adapt this over there with some other features too |
s-rschie
reviewed
Jan 19, 2024
| @@ -314,6 +316,26 @@ public void setControls(final ReactExoplayerView videoView, final boolean contro | |||
| videoView.setControls(controls); | |||
| } | |||
|
|
|||
| @ReactProp(name = PROP_ENABLE_MEDIA_SESSION, defaultBoolean = false) | |||
| public void setEnabledMediaSession(final ReactExoplayerView videoView, final boolean enableMediaSession) { | |||
There was a problem hiding this comment.
I'm not sure, but wanted to double check just in case. Is there a spelling error here?
Suggested change
| public void setEnabledMediaSession(final ReactExoplayerView videoView, final boolean enableMediaSession) { | |
| public void setEnableMediaSession(final ReactExoplayerView videoView, final boolean enableMediaSession) { |
s-rschie
reviewed
Jan 19, 2024
|
This is now implemented via #3723 - if I missed something please let me know |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Media Session
This adds 2 props,
enableMediaSessionandmediaSessionMetadata. With these the video can create an Android Media Session and provide it with metadata.Simply adding a media session like this allows the video to be controlled and respond to a number of external controls. Some examples include:
Testing
Because this opens the door to many controls there are number of ways it can be tested. I've been testing 2 different ways:
Trigger pause/play event through adb
You can mimic the event of pressing a pause/play button through adb.
adb shell input keyevent 126Key 126 is PLAY, 127 is PAUSE, 85 is PLAY/PAUSE. See more event codes in the Android docs here
Google Assistant
You can run on a device that has Google Assistant, then test instructions such as "Play"/"Pause"/"What's Playing?"
Pretty sure you can also use Google Assistant in emulators