Fix: Incorrect name of China Patriotism upgrade #2702
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmgreeny
added
Minor
xezon
reviewed
Mar 21, 2025
|
All fixed and ready to merge |
Windstalker
approved these changes
Apr 17, 2025
xezon
changed the title
xezon
changed the title
xezon
reviewed
Apr 17, 2025
| changes: | ||
| - fix: Changes text of all localization to match US localization | ||
|
|
||
| subchanges: |
|
|
||
| title: Improves texts of Fanaticism upgrade | ||
|
|
||
|
|
|
|
||
| labels: | ||
| - minor | ||
| - text |
| RU: "Патриотизм: &P" | ||
| AR: "ﺔﯿﻨﻃﻮﻟا" | ||
| AR: "Patriotism: &P" |
There was a problem hiding this comment.
Arabic is changed to English here.
Twice.
| --- | ||
| date: 2025-03-28 | ||
|
|
||
| title: Improves texts of Fanaticism upgrade |
There was a problem hiding this comment.
Fixes incorrect name of China Patriotism upgrade for all languages
|
|
||
|
|
||
| changes: | ||
| - fix: Changes text of all localization to match US localization |
There was a problem hiding this comment.
The China Patriotism upgrade is no longer labeled as Fanaticism.
xezon
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change renames strings of the China upgrade from Fanaticism to Patriotism to match the actual voice lines.
As discussed here #2632