-
Notifications
You must be signed in to change notification settings - Fork 121
[GEN][ZH] Enable Control Bar toggle for Replay playback and match observers #854
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
helmutbuhler
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good and works as advertised
|
I think this change is incomplete. GenTool puts NOP's in 5 locations. So for example the Command Bar cannot be toggled as Match Observer, which has 2 states: Native Match Observer and Player Observer after Surrender. And also toggle has 2 ways: F9, and Button in Control Bar. |
I've tested it and the toggle works for both type of observers. F9 is not toggling the control bar, but hiding the entire UI, and thus a different functionality. For it to work, the if statement on line 3181 in CommandXlat.cpp needs to be removed. I've pushed the F9 fix to @Mauller's commit. It should be all good to go now. |
xezon
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look correct. Control bar is toggling.
There can be some additional cleanups done I think.
Generals/Code/GameEngine/Source/GameClient/MessageStream/CommandXlat.cpp
Show resolved
Hide resolved
…ervers (TheSuperHackers#854) Co-authored-by: Bart Roossien <bart.roossien@energygo.nl>
Squash and merge
This PR removes the early return that was preventing the command bar size control from working during replays.