Skip to content

[GEN][ZH] Compile out duplicate serial check in LAN lobby #789

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 1, 2025

Conversation

xezon
Copy link

@xezon xezon commented May 1, 2025

Merge with Rebase

This change compiles out the duplicate serial check in LAN lobby. This is a requirement for running multiple clients locally.

@xezon xezon added Major Severity: Minor < Major < Critical < Blocker Network Anything related to network, servers labels May 1, 2025
@xezon xezon added this to the Code foundation build up milestone May 1, 2025
@xezon xezon requested a review from helmutbuhler May 1, 2025 11:04
@xezon xezon force-pushed the xezon/remove-serial-check branch from 5df3d43 to 1a40224 Compare May 1, 2025 11:04
Copy link

@helmutbuhler helmutbuhler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@xezon xezon merged commit 16343f3 into TheSuperHackers:main May 1, 2025
18 checks passed
@xezon xezon deleted the xezon/remove-serial-check branch May 1, 2025 15:12
@xezon xezon added Gen Relates to Generals ZH Relates to Zero Hour Enhancement Is new feature or request labels May 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Is new feature or request Gen Relates to Generals Major Severity: Minor < Major < Critical < Blocker Network Anything related to network, servers ZH Relates to Zero Hour
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants