Skip to content

[GEN] Backport various crash and memory fixes from Zero Hour #692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 17, 2025

Conversation

tomsons26
Copy link

@tomsons26 tomsons26 commented Apr 16, 2025

Partial split from #688

  • ZH BuddyThread.cpp fixes string assignment
  • ControlBar.cpp fixes invalid science vector access, fixes memory leak on rightHUDCameoWindow, adds various null checks
  • ControlBarCommand.cpp adds various null checks
  • ControlBarCommandProcessing.cpp adds various null checks
  • ControlBarMultiSelect.cpp adds various null checks
  • Debug.cpp adds various null checks
  • DozerAIUpdate.cpp - fixes out of bounds crash on invalid task id
  • GlobalData.cpp - fixes dangling TheWritableGlobalData pointer
  • MiniLog.cpp - fixes crash when m_fp is null
  • Mouse.cpp - fixes crash when m_cursorTextDisplayString is null
  • RankInfo.cpp - fixes memory leak
  • RankInfo.h
  • Science.cpp - fixes memory leak
  • Science.h
  • SkirmishGameOptionsMenu.cpp adds various null checks
  • SparseMatchFinder.h adds various null checks
  • TerrainLogic.cpp - fixes crash when tower is null
  • W3DBibBuffer.cpp - fixes crash when there's nothing in buffer
  • W3DBridgeBuffer.cpp - fixes crash when there's not enough room in buffer
  • W3DTruckDraw.cpp - fixes crash when Tire Bones are null
  • W3DWater.cpp - fixes crash when bumpsource is null
  • W3dWaypointBuffer.cpp - fixes two memory leaks
  • WorkerAIUpdate.cpp - fixes out of bounds crash on invalid task id
  • Xfer.cpp - fixes incorrect forced crash when science vector isn't empty

@tomsons26 tomsons26 marked this pull request as ready for review April 16, 2025 10:25
@xezon xezon added this to the Code foundation build up milestone Apr 16, 2025
@xezon xezon added Bug Something is not working right Major Severity: Minor < Major < Critical < Blocker Gen Relates to Generals Fix Is fixing something Unify Unifies code between Generals and Zero Hour labels Apr 16, 2025
@xezon xezon changed the title [GEN] Backports various memory fixes from ZH [GEN] Backport various crash and memory fixes from Zero Hour Apr 16, 2025
Copy link

@xezon xezon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@xezon xezon merged commit df022c9 into TheSuperHackers:main Apr 17, 2025
21 checks passed
@tomsons26 tomsons26 deleted the backportmemfix branch April 19, 2025 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is not working right Fix Is fixing something Gen Relates to Generals Major Severity: Minor < Major < Critical < Blocker Unify Unifies code between Generals and Zero Hour
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants