tweak(metaevent): Change COMMANDUSABLE_OBSERVER to no longer apply in Shell Map #2002
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xezon
added
Design
Stubbjax
approved these changes
Dec 17, 2025
bobtista
reviewed
Dec 17, 2025
| Bool isPlayerActive(void) const; | ||
| Bool isPlayerObserver( void ) const; // Favor !isPlayerActive() - this is used for Observer GUI mostly, not in-game stuff | ||
| Bool isPlayerDead(void) const; // Favor !isPlayerActive() - this is used so OCLs don't give us stuff after death. | ||
| Bool isPlayerActive(void) const; // Player is alive and no observer. !isPlayerActive() is synonymous for observing. |
There was a problem hiding this comment.
nit:
no observer -> non-observer or not observer
synonymous for -> synonymous with
|
LGTM, though I think the local player should be an observer in the shell map. 🤷 |
Skyaero42
approved these changes
Dec 17, 2025
Skyaero42
left a comment
Skyaero42
left a comment
There was a problem hiding this comment.
Tested and it works as advertised :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes
COMMANDUSABLE_OBSERVERto no longer apply in Shell Map. It applies when observing (including Replay).Previously buttons P and O took affect in Shell Map. But this causes confusion because players press these buttons in the lobby when typing messages.
The Shell Map can still be paused and stepped with Shift+P, Shift+O.
This change does not really fix #1945