chore: Add custom clang-tidy plugin for isEmpty() checks

[bobtista]

Extends the clang-tidy readability-container-size-empty check to our other string types

• AsciiString/UnicodeString: getLength() == 0 → isEmpty()

• StringClass/WideStringClass: Get_Length() == 0 → Is_Empty()

• Also handles !=, >, and <= comparisons

• Documentation - README with build and usage instructions

Example Fixes

// Before
if (str.getLength() == 0) { ... }
if (str.Get_Length() > 0) { ... }

// After
if (str.isEmpty()) { ... }
if (!str.Is_Empty()) { ... }## Usage

clang-tidy -p build/clang-tidy
--checks='-*,generals-use-is-empty'
-load tools/clang-tidy-plugin/build/lib/libGeneralsGameCodeClangTidyPlugin.so
-fix-errors
file.cpp## Testing

[xezon]

Is AsciiString::compare, AsciiString::compareNoCase, UnicodeString::compare, ... also supported?

[bobtista]

Is AsciiString::compare, AsciiString::compareNoCase, UnicodeString::compare, ... also supported?

Yes, both are implemented inline:
compare() uses wcscmp()
compareNoCase() uses _wcsicmp()
All four methods are in the Core headers

[xezon]

I mean will it work together with the clang tidy refactor:

if (myAscii.compare(otherAscii)) {}

[xezon]

I looked in this change for keywords "compare" and "compareNoCase" and there was no match found. So I suspect that is missing.

Looks incomplete

[bobtista]

Is AsciiString::compare, AsciiString::compareNoCase, UnicodeString::compare, ... also supported?

I misunderstood., sorry! Added this for both compare and compareNoCase

// Before
if (myAscii.compare("") == 0) { }
if (myUnicode.compare(L"") == 0) { }

// After
if (myAscii.isEmpty()) { }
if (myUnicode.isEmpty()) { }