bugfix(radar): Add hero radar objects into its own list to get rid of hero cache updates and its related issues #1893
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xezon
added
Bug
xezon
force-pushed
the
xezon/fix-hero-radar-2
branch
2 times, most recently
from
98b5355 to
3bd7411
Compare
Skyaero42
requested changes
Nov 23, 2025
GeneralsMD/Code/GameEngineDevice/Source/W3DDevice/Common/System/W3DRadar.cpp
Outdated
Show resolved
Hide resolved
| Bool W3DRadar::canRenderObject( const RadarObject *rObj, const Player *localPlayer ) | ||
| { | ||
| if (rObj->isTemporarilyHidden()) | ||
| return false; |
There was a problem hiding this comment.
You are using if-brackets for every other if statement in this function, while the original code did not. For consistency, I would also use brackets here.
| while( *list ) | ||
| { | ||
|
|
||
| // get next object |
There was a problem hiding this comment.
Can remove comment as well. code is self-explanatory
| m_localObjectList->friend_getObject()->friend_setRadarData( NULL ); | ||
| (*list)->friend_getObject()->friend_setRadarData( NULL ); | ||
|
|
||
| // delete the head of the list |
There was a problem hiding this comment.
remove comment for self-explanatory code
| for( Object *obj = TheGameLogic->getFirstObject(); obj; obj = obj->getNextObject() ) | ||
| { | ||
|
|
||
| DEBUG_ASSERTCRASH( obj->friend_getRadarData() == NULL, ("oops") ); |
There was a problem hiding this comment.
Maybe take the opportunity for a more descriptive assert message.
xezon
force-pushed
the
xezon/fix-hero-radar-2
branch
from
3bd7411 to
41559c0
Compare
… hero cache updates and its related issues (#1893)
xezon
force-pushed
the
xezon/fix-hero-radar-2
branch
from
41559c0 to
fd63484
Compare
Author
|
Rebased on main. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge with Rebase
This change adds hero radar objects into its own list to get rid of hero cache updates and its related issues. As a side benefit the local radar object list render update is now also marginally cheaper because it no longer needs to update the hero objects cache.
This change contains 4 commits, of which 3 are refactors to simplify some Radar functions to make them reusable in other call sites.
TODO