Skip to content

refactor: Simplify some if-else condition chains #1683

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Nov 8, 2025
Merged

refactor: Simplify some if-else condition chains #1683

merged 7 commits into from
Nov 8, 2025

Conversation

@bobtista
Copy link

@bobtista bobtista commented Oct 10, 2025

Refactored:

  • Recorder::readArgument(): 11-deep enum dispatch for argument types
  • UDP::GetStatus(): Windows (11-deep) and Unix (12-deep) error code mapping
  • NAT::allConnectionsDone(): 7-deep player count logic

Mauller
Mauller reviewed Oct 10, 2025
View reviewed changes
Mauller
Mauller reviewed Oct 10, 2025
View reviewed changes
xezon
xezon approved these changes Nov 7, 2025
View reviewed changes
@xezon xezon added Refactor Edits the code with insignificant behavior changes, is never user facing Approved Pull Request was approved labels Nov 7, 2025
xezon
xezon reviewed Nov 8, 2025
View reviewed changes
@bobtista
refactor(network): further simplify allConnectionsDone() logic
0a8618c 
Use bitwise AND to detect odd/even numbers and calculate required rounds
more concisely.

Addresses xezon's review comment on PR TheSuperHackers#1683
@bobtista
fix indentation in Recorder switch cases
c61b32e 
Properly align break statements and closing braces to match case block
indentation.

Addresses xezon's review comment on PR TheSuperHackers#1683
@bobtista bobtista force-pushed the bobtista/switch-refactor-2 branch from 367b3cd to c61b32e Compare November 8, 2025 12:23
@xezon xezon changed the title refactor: convert more if-else chains to switch statements refactor: Simplify some if-else condition chains Nov 8, 2025
@xezon xezon merged commit e404977 into TheSuperHackers:main Nov 8, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xezon xezon xezon approved these changes

@Skyaero42 Skyaero42 Skyaero42 left review comments

@Mauller Mauller Mauller left review comments

@Caball009 Caball009 Caball009 left review comments

+1 more reviewer

@johnneijzen johnneijzen johnneijzen left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Approved Pull Request was approved Refactor Edits the code with insignificant behavior changes, is never user facing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@bobtista @johnneijzen @xezon @Skyaero42 @Mauller @Caball009