-
Notifications
You must be signed in to change notification settings - Fork 121
feat(gui): Implement money per minute display for local player #1481
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
What pain points does this feature solve? Is it not something skilled players can already intuit? Are the benefits worth the added complexity / cost to readability? |
|
Only game I know of that inlines the resource per min data point similar to this is Supreme Commander. But that game is a supply chain simulator compared to ZH. Starcraft 2 has an income tab in replay mode only, so you can't see it while you're playing. income/min is useful if you're studying your replays and helps spectators understand the economy game, but I reckon not so much for the player himself. |
A lot of people who watch Legis stream are often interested in his |
|
I think this is a nice addition. I'd append the unit "/min" though to make it clearer what it means. |
I don't think this is possible while remaining ControlBarPro addon compatibility as It has much less space in the money texture compared to the original game's ControlBar |
Even if it overflows, it's fine. Someone will make an updated ControlBarPro addon soon that fixes the texture. And until then, you can still disable it. |
|
I'd leave the money display alone, and put this data into top-left corner together with other GenTool things. I'd be interested in seeing this data, but putting it next to current money might hinder comprehension speed |
|
Perhaps it would be better suited for an Observer specific display. |
Frankly, it would be great fun to see this while playing singleplayer |
The money display is left alone. This feature is disabled by default now. I think it makes more sense this way. |
|
Rebased onto main and addressed all comments |
GeneralsMD/Code/GameEngine/Source/GameLogic/ScriptEngine/ScriptActions.cpp
Outdated
Show resolved
Hide resolved
GeneralsMD/Code/GameEngine/Source/GameClient/GUI/GUICallbacks/Menus/OptionsMenu.cpp
Outdated
Show resolved
Hide resolved
xezon
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks pretty solid. Just a few more questions left to tackle.
|
Updated. |
|
Updated and rebased on main. |
xezon
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs to be replicated to Generals
|
Yeah I can make a follow up change to make the money per minute update interval configurable, while keeping the current behavior as the default.
That is outside the scope of this change. |
|
@L3-M , can you please let me know which control bar you are using, im using genpatcher and both exile and xezons control bars arent displaying the income per min correctly, the box width is small and the text is wrapped so not readable. the original control bar wirks perfectly though, but i dont use it |
I am using a custom version. You can check my fork for the changes required to adjust the money texture size: L3-M/GeneralsControlBar@4646736 I have also published a release for anyone who wants to use this change with the money feature: |
…perHackers#1481) Is disabled by default and can be enabled by setting ShowMoneyPerMinute=yes in Options.ini
This change implements player money per minute in Generals and Zero Hour.
Tracks income over the last 60 seconds. By default, it is disabled by "no" and can be enabled by the value "yes" in Options.ini.
By being disabled, it will fall back to the original current money only.
For example:
Note: Money per minute will not track income from canceling constructing buildings, canceling unit or upgrade production, or from surrendered player transfers, as these are not really "earned" by the player.
TODO