[GEN][ZH] Fix memory leaks within various AIAttackStateMachines #1351
Conversation
| @@ -735,6 +736,8 @@ AIStateMachine::~AIStateMachine() | |||
| { | |||
| deleteInstance(m_goalSquad); | |||
| } | |||
|
|
|||
| clear(); | |||
There was a problem hiding this comment.
This looks like it could change behaviour with what AIStateMachine does on clear?
There was a problem hiding this comment.
Yeah i just noticed that there is also the signal to the ai.
it could be that the changes here can disappear if the problem is just cleanup within the states themselves.
| @@ -1998,6 +2001,7 @@ AIAttackMoveStateMachine::AIAttackMoveStateMachine(Object *owner, AsciiString na | |||
| //---------------------------------------------------------------------------------------------------------- | |||
| AIAttackMoveStateMachine::~AIAttackMoveStateMachine() | |||
| { | |||
| clear(); | |||
There was a problem hiding this comment.
Various AIAttackstates that were appearing in the Generals shell map as being leaked after close.
I need to check back over it again later the same with the AIGuard state stuff.
There was a problem hiding this comment.
Checking it again, i think the issue is that the AIAttack states are leaking in a similar fashion to the guard states, i am going to repurpose this PR to implement their destructors and so that the other PR does not get too long.
There was a problem hiding this comment.
So the leaking AI Attack states were just ones leaking due to the issue with the AI Guard states, this PR does not actually do anything helpful in the end.
There was a problem hiding this comment.
It was generals that i was seeing the leaked states within still, but i might not have had the AIGuard leak fix in place then, i will double check if there are leaking AI states there still and close this later if it's not going to be useful.
|
Yeah this is not needed in the end so going to close it, i think i was seeing things which the AI Guard state PR resolved. |
This PR cleans up memory leaks within a few different AI state machines.