Skip to content

Conversation

@xezon
Copy link

@xezon xezon commented Jul 21, 2025

This change removes some superfluous files from the game folders.

No clue how that STLUtils.h ended up there via #1035. Totally missed that although aliendroid1 did mention it in the review.

@xezon xezon added this to the Code foundation build up milestone Jul 21, 2025
@xezon xezon added Minor Severity: Minor < Major < Critical < Blocker Refactor Edits the code with insignificant behavior changes, is never user facing labels Jul 21, 2025
@Mauller
Copy link

Mauller commented Jul 22, 2025

I think you missed that the browser engine dll is required.

@xezon
Copy link
Author

xezon commented Jul 22, 2025

Oh right we use it to generate a file. Nevermind then. I will revert that.

@xezon xezon force-pushed the xezon/remove-superfluous-stlutils branch from 7531381 to 3409f05 Compare July 22, 2025 20:42
@xezon
Copy link
Author

xezon commented Jul 22, 2025

BrowserEngine restored

Copy link

@Mauller Mauller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@xezon xezon merged commit 62d54eb into TheSuperHackers:main Jul 22, 2025
14 checks passed
@xezon xezon deleted the xezon/remove-superfluous-stlutils branch July 22, 2025 20:58
fbraz3 pushed a commit to fbraz3/GeneralsX that referenced this pull request Nov 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Minor Severity: Minor < Major < Critical < Blocker Refactor Edits the code with insignificant behavior changes, is never user facing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants