[ZH] Fix RenderObjClass memory leaks in W3DPropBuffer #1319
Conversation
| @@ -119,7 +116,8 @@ W3DPropBuffer::W3DPropBuffer(void) | |||
| { | |||
| memset(this, sizeof(W3DPropBuffer), 0); | |||
| m_initialized = false; | |||
| clearAllProps(); | |||
| m_numProps = 0; | |||
| m_numPropTypes = 0; | |||
| m_light = NEW_REF( LightClass, (LightClass::DIRECTIONAL) ); | |||
There was a problem hiding this comment.
m_numProps and m_numPropTypes are already set to zero in clearAllProps()
There was a problem hiding this comment.
They aren't initialised before this point, so since the loops were changed to use m_numPropTypes and m_numProps as their range, it could cause invalid behaviour as those variables have not been set yet.
There was a problem hiding this comment.
I replaced the call to clearAllProps() because there is nothing clear.
Technically even m_numProps = 0, m_numPropTypes = 0 are useless because of the memset(this, sizeof(W3DPropBuffer), 0); above, but nevermind that.
The constructor also sets m_initialized twice :D Nevermind the mess.
There was a problem hiding this comment.
The memset doesn't do anything here btw (0 parameter size).
|
Since you're refactoring the constructor of |
|
Is ok, can be separate change. |
This change fixes the RenderObjClass memory leaks in W3DPropBuffer. Is Zero Hour specific issue.
Tested by loading into Shell Map, into 1 Skirmish Map, and exit game. It would leak about 200 kb in this test.
Roughly the leaks marked with red are related to this