Changing resolution in Options menu will reset IP addresses to first in list

[xezon]

Changing resolution in Options menu will reset IP addresses to first in list. I mark this bug as Critical, because this behaviour is reason number 1 why people complain about not being able to join Online Lobby or no longer see Network rooms all of a sudden. They change resolution and don't expect the IP address to reset along with it for no apparent reason. Players end up opening topics in forums and asking for solutions. Telling players to check IP solves all issues in most cases.

[Demonbarrage]

The issue occurs in OptionsMenu.cpp in the saveOptions() function when TheShell is deleted and null'ed:

delete TheShell; TheShell = NULL;

The fix is to move the IP Address block:
//-------------------------------------------------------------------------------- // IP address UnsignedInt ip; GadgetComboBoxGetSelectedPos(comboBoxLANIP, &index); if (index>=0 && TheGlobalData) { ip = (UnsignedInt)GadgetComboBoxGetItemData(comboBoxLANIP, index); TheWritableGlobalData->m_defaultIP = ip; pref->setLANIPAddress(ip); } GadgetComboBoxGetSelectedPos(comboBoxOnlineIP, &index); if (index>=0) { ip = (UnsignedInt)GadgetComboBoxGetItemData(comboBoxOnlineIP, index); pref->setOnlineIPAddress(ip); }

To above the Resolution block:
`//-------------------------------------------------------------------------------------------------
// Resolution
GadgetComboBoxGetSelectedPos( comboBoxResolution, &index );
Int xres, yres, bitDepth;

oldDispSettings.xRes = TheDisplay->getWidth();
oldDispSettings.yRes = TheDisplay->getHeight();
oldDispSettings.bitDepth = TheDisplay->getBitDepth();
oldDispSettings.windowed = TheDisplay->getWindowed();

if (index < TheDisplay->getDisplayModeCount() && index >= 0)
{
	TheDisplay->getDisplayModeDescription(index,&xres,&yres,&bitDepth);
	if (TheGlobalData->m_xResolution != xres || TheGlobalData->m_yResolution != yres)
	{
		
		if (TheDisplay->setDisplayMode(xres,yres,bitDepth,TheDisplay->getWindowed()))
		{
			dispChanged = TRUE;
			TheWritableGlobalData->m_xResolution = xres;
			TheWritableGlobalData->m_yResolution = yres;

			TheHeaderTemplateManager->headerNotifyResolutionChange();
			TheMouse->mouseNotifyResolutionChange();
			
			//Save new settings for a dialog box confirmation after options are accepted
			newDispSettings.xRes = xres;
			newDispSettings.yRes = yres;
			newDispSettings.bitDepth = bitDepth;
			newDispSettings.windowed = TheDisplay->getWindowed();

			AsciiString prefString;
			prefString.format("%d %d", xres, yres );
			(*pref)["Resolution"] = prefString;

			// delete the shell
			delete TheShell;
			TheShell = NULL;

			// create the shell
			TheShell = MSGNEW("GameClientSubsystem") Shell;
			if( TheShell )
				TheShell->init();
			
			TheInGameUI->recreateControlBar();

			TheShell->push( AsciiString("Menus/MainMenu.wnd") );
		}
	}
}`

The GadgetComboBoxGetSelectedPos() takes a GameWindow *comboBox parameter that is being null'ed by TheShell deletion. Saving IP settings before deleting resolves the issue.

I will learn to make and perform a pull request to change this!! First contribution to large project ever and it was extremely satisfying to fix!