mypy: Exclude only 20 files that are still failing

[cclauss]

Let's see what is required to finish #4052

Describe your change:

• Add an algorithm?
• Fix a bug or typo in an existing algorithm?
• Documentation change?

Checklist:

• I have read CONTRIBUTING.md.
• This pull request is all my own work -- I have not plagiarized.
• I know that pull requests will not be merged if they fail the automated tests.
• This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
• All new Python files are placed inside an existing directory.
• All filenames are in all lowercase characters with no spaces or dashes.
• All functions and variable names follow Python naming conventions.
• All function parameters and return values are annotated with Python type hints.
• All functions have doctests that pass the automated testing.
• All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
• If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

[cclauss]

>>> from collections import Counter
>>> with open("mypy_output.txt") as in_file:
...     print(Counter(line.split("/")[0] for line in in_file))
...

Counter({'data_structures': 147, 'other': 56, 'searches': 45, 'matrix': 15, 'maths': 14, 'graphs': 10})

Fyi @spazm @archaengel @dylanbuchi @ErwinJunge @shermanhui

[spazm]

>>> from collections import Counter
>>> with open("mypy_output.txt") as in_file:
...     print(Counter(line.split("/")[0] for line in in_file))
...

Counter({'data_structures': 147, 'other': 56, 'searches': 45, 'matrix': 15, 'maths': 14, 'graphs': 10})

Fyi @spazm @archaengel @dylanbuchi @ErwinJunge @shermanhui

The numbers are total number of errors per directory. The files per directory are lower.

On current master (11a15cc)

% git checkout master

% (mypy --ignore-missing-imports --install-types --non-interactive *(/) 2>&1 >/dev/null)| cut -f1 -d: | sort | uniq |  cut -f1 -d/ | sort | uniq -c
      8 data_structures
      4 graphs
      5 maths
      1 matrix
      7 other
      2 searches
      5 ven

[cclauss]

Found 204 errors in 24 files (checked 976 source files)

30 fixed in data_structures

Counter({'data_structures': 117, 'other': 51, 'searches': 45, 'matrix': 15, 'maths': 14, 'graphs': 10})

[spazm]

other/ will be clean when the PRs in-fligh are landedt: #5647, #5648, #5653, #5656, and #5755.

The middle three were autoclosed by the bot for "multiple PR detected", so if they could be re-opened and reviewed, that'd be appreciated. [ #5648 #5653 #5656 ]

% git checkout mypy-fix-other-all

% mypy --ignore-missing-imports --install-types
Success: no issues found in 21 source files

[dylanbuchi]

The middle three were autoclosed by the bot for "multiple PR detected", so if they could be re-opened and reviewed, that'd be appreciated. [ #5648 #5653 #5656 ]

Hey @spazm. PR's can't be reopened! You'll have to create new pull requests.

[spazm]

Hey @spazm. PR's can't be reopened! You'll have to create new pull requests.

Thanks for the info. It's a bummer, of course.

[cclauss]

Improvements!

./graphs          || true  # Errors: 10  -> 9
./maths           || true  # Errors: 14  -> 14
./matrix          || true  # Errors: 15  -> 15
./searches        || true  # Errors: 45  -> 21
./other           || true  # Errors: 51  -> 43
./data_structures || true  # Errors: 117 -> 67

Perhaps we should start mypy --exclude individual files.

[cclauss]

with open("mypy_output.txt") as in_file:
    filenames = sorted({line.split(':')[0] for line in in_file if ':' in line})

print(f"{len(filenames) = }")
# print("\n".join(f"                  --exclude {name}" for name in filenames))
print(f"--exclude ({'|'.join(filenames)})")

[cclauss]

@dhruvmanila Please let me know why the mypy.ini exclude is not working.

[ErwinJunge]

@dhruvmanila Please let me know why the mypy.ini exclude is not working.

Probably due to the mv mypy.ini was_mypy.ini here: https://github.com/TheAlgorithms/Python/pull/5608/files#diff-5c3fa597431eda03ac3339ae6bf7f05e1a50d6fc7333679ec38e21b337cb6721R31

After removing that, it most likely still won't work, since you're calling mypy with specific directories. The exclude regex needs to be relative to the directory that is used as the root for discovery.

[cclauss]

I was talking about the mypy run on line 24.

[cclauss]

@dylanbuchi AWESOME!! I own you a beer!!

[dhruvmanila]

A small nitpick, otherwise LGTM 👍

[dhruvmanila]

Maybe this could be done on multiline if possible for better readability. If not possible, then ignore this comment.