Skip to content

mypy: Exclude only 20 files that are still failing #5608

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 23 commits into from
Nov 6, 2021
Merged

mypy: Exclude only 20 files that are still failing #5608

Changes from 1 commit
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
a68cc16
DRAFT: Run a mypy reality check
cclauss Oct 26, 2021
275615b
mypy --ignore-missing-imports --install-types --non-interactive
cclauss Oct 26, 2021
43df758
Check our progress...
cclauss Oct 29, 2021
8ced76c
Update build.yml
cclauss Oct 29, 2021
5273f52
Update build.yml
cclauss Nov 3, 2021
c8b64a8
Update build.yml
cclauss Nov 3, 2021
8ea9fab
Update build.yml
cclauss Nov 4, 2021
967e1bd
mypy --exclude 20 files
cclauss Nov 5, 2021
471e638
--exclude with no `=`
cclauss Nov 5, 2021
14633a1
Update build.yml
cclauss Nov 5, 2021
f073fe7
558 character regex!!!
cclauss Nov 5, 2021
b0a5549
With quotes
cclauss Nov 5, 2021
2d65941
mypy.ini: mega exclude
cclauss Nov 5, 2021
ffad6f5
Update mypy.ini
cclauss Nov 5, 2021
105c1f4
Update build.yml
cclauss Nov 5, 2021
f972c84
Update mypy.ini
cclauss Nov 5, 2021
9c621d3
Update build.yml
cclauss Nov 5, 2021
0091d5c
Update mypy.ini
cclauss Nov 5, 2021
9404b67
.py --> .p*
cclauss Nov 5, 2021
3bfb2b6
Escape the dots!: `.` --> `\.`
cclauss Nov 5, 2021
dcefccb
Remove the comment
cclauss Nov 5, 2021
535988e
Leading slash
cclauss Nov 5, 2021
36d2c4b
Update mypy.ini
cclauss Nov 5, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Update mypy.ini 
Co-authored-by: Dylan Buchi <devybuchi@gmail.com>
  • Loading branch information
@cclauss @dylanbuchi
cclauss and dylanbuchi authored Nov 5, 2021
commit 36d2c4bdd6ab2685948d30bdcc9589faf25eb44d
3 changes: 2 additions & 1 deletion mypy.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,5 @@
ignore_missing_imports = True
install_types = True
non_interactive = True
exclude = /(data_structures/stacks/next_greater_element\.py|graphs/boruvka\.py|graphs/breadth_first_search\.py|graphs/breadth_first_search_2\.py|graphs/check_cycle\.py|graphs/finding_bridges\.py|graphs/greedy_min_vertex_cover\.py|graphs/random_graph_generator\.py|maths/average_mode\.py|maths/gamma_recursive\.py|maths/proth_number\.py|maths/series/geometric_series\.py|maths/series/p_series\.py|matrix/matrix_operation\.py|other/fischer_yates_shuffle\.py|other/least_recently_used\.py|other/lfu_cache\.py|other/lru_cache\.py|searches/simulated_annealing\.py|searches/ternary_search\.py)$
exclude = (data_structures/stacks/next_greater_element.py|graphs/boruvka.py|graphs/breadth_first_search.py|graphs/breadth_first_search_2.py|graphs/check_cycle.py|graphs/finding_bridges.py|graphs/greedy_min_vertex_cover.py|graphs/random_graph_generator.py|maths/average_mode.py|maths/gamma_recursive.py|maths/proth_number.py|maths/series/geometric_series.py|maths/series/p_series.py|matrix_operation.py|other/fischer_yates_shuffle.py|other/least_recently_used.py|other/lfu_cache.py|other/lru_cache.py|searches/simulated_annealing.py|searches/ternary_search.py)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe this could be done on multiline if possible for better readability. If not possible, then ignore this comment.