Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CODEOWNERS file to TheAlgorithms/Python #3147

Merged
merged 2 commits into from
Oct 10, 2020

Conversation

dhruvmanila
Copy link
Member

Fixes: #3011

This is the basic structure of the file as mentioned in the issue. All the directories have been separated out to ease up assigning it to the maintainers. We can also assign specific file type or single files as well such as the configuration files like .travis.yml, .pre-commit-config.yml and so on.

Describe your change:

  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@dhruvmanila dhruvmanila changed the title Add CODEOWNERS file Add CODEOWNERS file to TheAlgorithms/Python Oct 10, 2020
@dhruvmanila dhruvmanila requested a review from cclauss October 10, 2020 05:52
@dhruvmanila
Copy link
Member Author

Is this enough for now? This will only notify the two of us.

Also, can you take a look at #3094
Thanks if you do.

@cclauss cclauss marked this pull request as ready for review October 10, 2020 14:38
@cclauss cclauss merged commit c961d55 into TheAlgorithms:master Oct 10, 2020
@dhruvmanila dhruvmanila deleted the add-codeowners branch October 10, 2020 15:48
stokhos pushed a commit to stokhos/Python that referenced this pull request Jan 3, 2021
* Add CODEOWNERS file

* Commented out the non-assigned directory
Panquesito7 pushed a commit to Panquesito7/Python that referenced this pull request May 13, 2021
* Add CODEOWNERS file

* Commented out the non-assigned directory
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Should we implement CODEOWNERS for the directories of this repo?
2 participants