Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Project Euler] Fix code style for multiple problems #3094

Merged
merged 3 commits into from
Oct 10, 2020
Merged

[Project Euler] Fix code style for multiple problems #3094

merged 3 commits into from
Oct 10, 2020

Conversation

dhruvmanila
Copy link
Member

@dhruvmanila dhruvmanila commented Oct 9, 2020 •
edited
Loading

Continuing #2786

  • Fix code style for Project Euler problem 13, 17, 21, 31, 33, 43, 44, 46, 63, 551
  • Default arguments
  • Type hints
  • File path

Describe your change:

  • Fix a bug or typo in an existing algorithm?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.

@dhruvmanila
Fix code style for Project Euler problems:
2080191 
- 13, 17, 21
- Default args
- Type hints
- File path
@dhruvmanila dhruvmanila changed the title Fix code style for Project Euler problems: [Project Euler] Fix code style for problems 13, 17, 21 Oct 9, 2020
@dhruvmanila dhruvmanila changed the title [Project Euler] Fix code style for problems 13, 17, 21 [Project Euler] Fix code style for multiple problems Oct 9, 2020
@dhruvmanila dhruvmanila added the awaiting reviews This PR is ready to be reviewed label Oct 9, 2020
@dhruvmanila
Copy link
Member Author

Now only one file is left to fix but that is the problem:
problem_234/sol1.py has a line which shouldn't be there which asks for input for every loop (Number of loops as per the question: 999966663333). Can anyone take a look at that?

Also, now the script is taking 2 minutes to run as it's checking every single solution and some of them are brute force so that takes up a lot of time. I suggest to make this a separate job.

@dhruvmanila dhruvmanila mentioned this pull request Oct 9, 2020
Merged
14 tasks
@dhruvmanila
Copy link
Member Author

@shellhub Kush1101 Hey can anyone review this? Thanks

@dhruvmanila dhruvmanila mentioned this pull request Oct 10, 2020
Merged
6 tasks
@dhruvmanila dhruvmanila merged commit 501a2ff into TheAlgorithms:master Oct 10, 2020
@dhruvmanila dhruvmanila deleted the patch-project-euler branch October 10, 2020 15:56
stokhos pushed a commit to stokhos/Python that referenced this pull request Jan 3, 2021
@dhruvmanila @stokhos
[Project Euler] Fix code style for multiple problems (TheAlgorithms#3094
d37d9e1 
)

* Fix code style for Project Euler problems:

- 13, 17, 21
- Default args
- Type hints
- File path

* Fix code style for multiple problems

* Made suggested changes
Panquesito7 pushed a commit to Panquesito7/Python that referenced this pull request May 13, 2021
@dhruvmanila
[Project Euler] Fix code style for multiple problems (TheAlgorithms#3094
037816f 
)

* Fix code style for Project Euler problems:

- 13, 17, 21
- Default args
- Type hints
- File path

* Fix code style for multiple problems

* Made suggested changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cclauss cclauss cclauss approved these changes

@Kush1101 Kush1101 Awaiting requested review from Kush1101

@realDuYuanChao realDuYuanChao Awaiting requested review from realDuYuanChao

Assignees
No one assigned
Labels
awaiting reviews This PR is ready to be reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dhruvmanila @cclauss