Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added solution for Project Euler problem 72 #3122

Merged
merged 7 commits into from
Oct 16, 2020
Merged

Added solution for Project Euler problem 72 #3122

merged 7 commits into from
Oct 16, 2020

Conversation

fpringle
Copy link
Contributor

@fpringle fpringle commented Oct 9, 2020 •
edited
Loading

Name: Counting fractions

Consider the fraction, n/d, where n and d are positive integers. If n<d and HCF(n,d)=1, it is called a reduced proper fraction.

If we list the set of reduced proper fractions for d ≤ 8 in ascending order of size, we get:

1/8, 1/7, 1/6, 1/5, 1/4, 2/7, 1/3, 3/8, 2/5, 3/7, 1/2, 4/7, 3/5, 5/8, 2/3, 5/7, 3/4, 4/5, 5/6, 6/7, 7/8

It can be seen that there are 21 elements in this set.

How many elements would be contained in the set of reduced proper fractions for d ≤ 1,000,000?

Reference: https://projecteuler.net/problem=72
Reference: #2695

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@fpringle fpringle changed the title Added solution for Project Euler problem 72. Fixes: #2695 Added solution for Project Euler problem 72. Reference: #2695 Oct 9, 2020
@fpringle fpringle changed the title Added solution for Project Euler problem 72. Reference: #2695 Added solution for Project Euler problem 72 Oct 10, 2020
dhruvmanila
dhruvmanila requested changes Oct 15, 2020
View reviewed changes
project_euler/problem_72/sol1.py Outdated Show resolved Hide resolved
project_euler/problem_72/sol1.py Outdated Show resolved Hide resolved
project_euler/problem_72/sol1.py Outdated Show resolved Hide resolved
@dhruvmanila dhruvmanila added the awaiting changes A maintainer has requested changes to this PR label Oct 15, 2020
dhruvmanila
dhruvmanila reviewed Oct 15, 2020
View reviewed changes
Copy link
Member

@dhruvmanila dhruvmanila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Announcement:

@fpringle

This message is sent to all pull requests which are OPEN, NOT MERGED, not containing 'wontfix' label and contains 'Project Euler' or 'Project' or 'Euler' (case doesn't matter) in their title. If this message doesn't apply to your pull request, please ignore this.

Message:

This is to notify all the users submitting a pull request for the Project Euler solution that the README.md file has been updated with all the style requirements necessary for the directory and solution files. Please read through it and make all the necessary changes required to your submission.

@fpringle fpringle requested a review from Kush1101 as a code owner October 15, 2020 08:45
@dhruvmanila dhruvmanila added merge conflicts Open a new PR or rebase on the latest commit and removed awaiting changes A maintainer has requested changes to this PR labels Oct 15, 2020
@dhruvmanila
Copy link
Member

Um, you just deleted the old problem and replaced it with your own. As of now, we are only accepting solutions to problems that do not exist in this repository and you need to stop making multiple pull request. Please only submit one PR at a time.

@fpringle
Copy link
Contributor Author

Um, you just deleted the old problem and replaced it with your own. As of now, we are only accepting solutions to problems that do not exist in this repository and you need to stop making multiple pull request. Please only submit one PR at a time.

My solution was added 6 days ago, the solution that I just deleted was added 3 days ago but merged before mine.
Commit history

@dhruvmanila
Copy link
Member

Then please change the file name for your solution to sol2.py

@dhruvmanila dhruvmanila removed the merge conflicts Open a new PR or rebase on the latest commit label Oct 15, 2020
@dhruvmanila
Copy link
Member

You're deleting the first solution. Please revert it back.

@dhruvmanila dhruvmanila added the awaiting changes A maintainer has requested changes to this PR label Oct 15, 2020
@fpringle
Copy link
Contributor Author

Apologies for the hastle, I'm new to contributing!

@dhruvmanila
Copy link
Member

You follow the guidelines perfectly well and so it is easier to review :)
Keep up the good work. From next time, make sure to open only one PR at a time.

@dhruvmanila dhruvmanila merged commit d8f5b31 into TheAlgorithms:master Oct 16, 2020
@dhruvmanila dhruvmanila removed the awaiting changes A maintainer has requested changes to this PR label Oct 16, 2020
@fpringle
Copy link
Contributor Author

From next time, make sure to open only one PR at a time.

Sure thing - I can see now why multiple pull requests can be annoying 🤣

@fpringle fpringle deleted the problem_72 branch October 16, 2020 09:52
stokhos pushed a commit to stokhos/Python that referenced this pull request Jan 3, 2021
@fpringle @stokhos
Add solution for Project Euler problem 72 (TheAlgorithms#3122)
1ca2292 
* Added solution for Project Euler problem 72.

* Update type annotations and 0-padding of the directory name. Reference: TheAlgorithms#3256

* Rename sol1.py to sol2.py

* Added newline at the end of sol2.py

* Revert sol1.py
Panquesito7 pushed a commit to Panquesito7/Python that referenced this pull request May 13, 2021
@fpringle
Add solution for Project Euler problem 72 (TheAlgorithms#3122)
e5f22e0 
* Added solution for Project Euler problem 72.

* Update type annotations and 0-padding of the directory name. Reference: TheAlgorithms#3256

* Rename sol1.py to sol2.py

* Added newline at the end of sol2.py

* Revert sol1.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhruvmanila dhruvmanila dhruvmanila approved these changes

@Kush1101 Kush1101 Awaiting requested review from Kush1101

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fpringle @dhruvmanila