-
-
Notifications
You must be signed in to change notification settings - Fork 46.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update README.md for Project Euler #3256
Conversation
Travis tests have failedHey @dhruvmanila, TravisBuddy Request Identifier: caff6b60-0dc4-11eb-9111-f326d0cb7f09 |
Travis tests have failedHey @dhruvmanila, TravisBuddy Request Identifier: 6be7cdb0-0dd9-11eb-964d-5d54b4986782 |
Hey, @cclauss Can you take a look at this? Thanks if you do. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's cool. I just add a few suggestions on wording, etc. Thank you for your pull request!🤩
Co-authored-by: John Law <johnlaw.po@gmail.com>
* Added solution for Project Euler problem 72. * Update type annotations and 0-padding of the directory name. Reference: #3256 * Rename sol1.py to sol2.py * Added newline at the end of sol2.py * Revert sol1.py
* Added solution for Project Euler problem 174. * Fixed import order and removed executable permission from sol1.py * Update docstrings, doctests, and annotations. Reference: #3256 * Update docstring * Update sol1.py Co-authored-by: Dhruv <dhruvmanila@gmail.com>
* Added solution for Project Euler problem 75. * Added doctest for solution() in project_euler/problem_75/sol1.py * Update docstring and 0-padding of directory name. Reference: #3256 * More descriptive variable names * Moved solution explanation to module-level docstring
* Added solution for Project Euler problem 38. Fixes: #2695 * Update docstring and 0-padding in directory name. Reference: #3256 * Renamed is_9_palindromic to is_9_pandigital. * Changed just-in-case return value for solution() to None. * Moved exmplanation to module-level docstring and deleted unnecessary import
* Added solution for Project Euler problemm problem 173. TheAlgorithms#2695 * Added docstring * Update formatting, doctest and annotations. Reference: TheAlgorithms#3256
* Added solution for Project Euler problem 74. Fixes: TheAlgorithms#2695 * Added doctest for solution() in project_euler/problem_74/sol1.py * Update docstrings and 0-padding of directory name. Reference: TheAlgorithms#3256
* Added solution for Project Euler problem 72. * Update type annotations and 0-padding of the directory name. Reference: TheAlgorithms#3256 * Rename sol1.py to sol2.py * Added newline at the end of sol2.py * Revert sol1.py
* Added solution for Project Euler problem 174. * Fixed import order and removed executable permission from sol1.py * Update docstrings, doctests, and annotations. Reference: TheAlgorithms#3256 * Update docstring * Update sol1.py Co-authored-by: Dhruv <dhruvmanila@gmail.com>
* Added solution for Project Euler problem 91. Reference: TheAlgorithms#2695 * Added doctest for solution() in project_euler/problem_91/sol1.py * Update docstring and 0-padding in directory name. Reference: TheAlgorithms#3256 * Update sol1.py Co-authored-by: Dhruv <dhruvmanila@gmail.com>
* Added solution for Project Euler problem 75. * Added doctest for solution() in project_euler/problem_75/sol1.py * Update docstring and 0-padding of directory name. Reference: TheAlgorithms#3256 * More descriptive variable names * Moved solution explanation to module-level docstring
* Added solution for Project Euler problem 38. Fixes: TheAlgorithms#2695 * Update docstring and 0-padding in directory name. Reference: TheAlgorithms#3256 * Renamed is_9_palindromic to is_9_pandigital. * Changed just-in-case return value for solution() to None. * Moved exmplanation to module-level docstring and deleted unnecessary import
* Added solution for Project Euler problem 87. Fixes: TheAlgorithms#2695 * Update docstring and 0-padding in directory name. Reference: TheAlgorithms#3256
* Added solution for Project Euler problem 129. * Added doctest for solution() in project_euler/problem_129/sol1.py * Update formatting. Reference: TheAlgorithms#3256 * More descriptive function and variable names, more doctests.
* Added solution for Project Euler problem 77. * Update docstrings, doctest, type annotations and 0-padding in directory name. Reference: TheAlgorithms#3256 * Implemented lru_cache, better type hints, more doctests for problem 77 * updating DIRECTORY.md * updating DIRECTORY.md * Added solution for Project Euler problem 77. Fixes: 2695 * Update docstrings, doctest, type annotations and 0-padding in directory name. Reference: TheAlgorithms#3256 * Implemented lru_cache, better type hints, more doctests for problem 77 * better variable names Co-authored-by: github-actions <${GITHUB_ACTOR}@users.noreply.github.com>
* Added solution for Project Euler problem 38. Fixes: TheAlgorithms#2695 * Update docstring and 0-padding in directory name. Reference: TheAlgorithms#3256 * Renamed is_9_palindromic to is_9_pandigital. * Changed just-in-case return value for solution() to None. * Moved exmplanation to module-level docstring and deleted unnecessary import
* Added solution for Project Euler problem 87. Fixes: TheAlgorithms#2695 * Update docstring and 0-padding in directory name. Reference: TheAlgorithms#3256
* Added solution for Project Euler problem 129. * Added doctest for solution() in project_euler/problem_129/sol1.py * Update formatting. Reference: TheAlgorithms#3256 * More descriptive function and variable names, more doctests.
* Added solution for Project Euler problem 77. * Update docstrings, doctest, type annotations and 0-padding in directory name. Reference: TheAlgorithms#3256 * Implemented lru_cache, better type hints, more doctests for problem 77 * updating DIRECTORY.md * updating DIRECTORY.md * Added solution for Project Euler problem 77. Fixes: 2695 * Update docstrings, doctest, type annotations and 0-padding in directory name. Reference: TheAlgorithms#3256 * Implemented lru_cache, better type hints, more doctests for problem 77 * better variable names Co-authored-by: github-actions <${GITHUB_ACTOR}@users.noreply.github.com>
* Update README.md for Project Euler * Add link to solution template * Add newlines for better separation * Add __name__ == __main__ block in template * Apply suggestions from code review Co-authored-by: John Law <johnlaw.po@gmail.com> * Improve introduction part Co-authored-by: John Law <johnlaw.po@gmail.com>
* Added solution for Project Euler problem 113. TheAlgorithms#2695 * Updated formatting and doctests. Reference: TheAlgorithms#3256
* Added solution for Project Euler problemm problem 173. TheAlgorithms#2695 * Added docstring * Update formatting, doctest and annotations. Reference: TheAlgorithms#3256
* Added solution for Project Euler problem 74. Fixes: TheAlgorithms#2695 * Added doctest for solution() in project_euler/problem_74/sol1.py * Update docstrings and 0-padding of directory name. Reference: TheAlgorithms#3256
* Added solution for Project Euler problem 72. * Update type annotations and 0-padding of the directory name. Reference: TheAlgorithms#3256 * Rename sol1.py to sol2.py * Added newline at the end of sol2.py * Revert sol1.py
* Added solution for Project Euler problem 174. * Fixed import order and removed executable permission from sol1.py * Update docstrings, doctests, and annotations. Reference: TheAlgorithms#3256 * Update docstring * Update sol1.py Co-authored-by: Dhruv <dhruvmanila@gmail.com>
* Added solution for Project Euler problem 91. Reference: TheAlgorithms#2695 * Added doctest for solution() in project_euler/problem_91/sol1.py * Update docstring and 0-padding in directory name. Reference: TheAlgorithms#3256 * Update sol1.py Co-authored-by: Dhruv <dhruvmanila@gmail.com>
* Added solution for Project Euler problem 75. * Added doctest for solution() in project_euler/problem_75/sol1.py * Update docstring and 0-padding of directory name. Reference: TheAlgorithms#3256 * More descriptive variable names * Moved solution explanation to module-level docstring
* Added solution for Project Euler problem 38. Fixes: TheAlgorithms#2695 * Update docstring and 0-padding in directory name. Reference: TheAlgorithms#3256 * Renamed is_9_palindromic to is_9_pandigital. * Changed just-in-case return value for solution() to None. * Moved exmplanation to module-level docstring and deleted unnecessary import
* Added solution for Project Euler problem 87. Fixes: TheAlgorithms#2695 * Update docstring and 0-padding in directory name. Reference: TheAlgorithms#3256
* Added solution for Project Euler problem 129. * Added doctest for solution() in project_euler/problem_129/sol1.py * Update formatting. Reference: TheAlgorithms#3256 * More descriptive function and variable names, more doctests.
* Added solution for Project Euler problem 77. * Update docstrings, doctest, type annotations and 0-padding in directory name. Reference: TheAlgorithms#3256 * Implemented lru_cache, better type hints, more doctests for problem 77 * updating DIRECTORY.md * updating DIRECTORY.md * Added solution for Project Euler problem 77. Fixes: 2695 * Update docstrings, doctest, type annotations and 0-padding in directory name. Reference: TheAlgorithms#3256 * Implemented lru_cache, better type hints, more doctests for problem 77 * better variable names Co-authored-by: github-actions <${GITHUB_ACTOR}@users.noreply.github.com>
* Added solution for Project Euler problem 38. Fixes: TheAlgorithms#2695 * Update docstring and 0-padding in directory name. Reference: TheAlgorithms#3256 * Renamed is_9_palindromic to is_9_pandigital. * Changed just-in-case return value for solution() to None. * Moved exmplanation to module-level docstring and deleted unnecessary import
* Added solution for Project Euler problem 87. Fixes: TheAlgorithms#2695 * Update docstring and 0-padding in directory name. Reference: TheAlgorithms#3256
* Added solution for Project Euler problem 129. * Added doctest for solution() in project_euler/problem_129/sol1.py * Update formatting. Reference: TheAlgorithms#3256 * More descriptive function and variable names, more doctests.
* Added solution for Project Euler problem 77. * Update docstrings, doctest, type annotations and 0-padding in directory name. Reference: TheAlgorithms#3256 * Implemented lru_cache, better type hints, more doctests for problem 77 * updating DIRECTORY.md * updating DIRECTORY.md * Added solution for Project Euler problem 77. Fixes: 2695 * Update docstrings, doctest, type annotations and 0-padding in directory name. Reference: TheAlgorithms#3256 * Implemented lru_cache, better type hints, more doctests for problem 77 * better variable names Co-authored-by: github-actions <${GITHUB_ACTOR}@users.noreply.github.com>
To see what it looks like: https://github.com/dhruvmanila/Python/blob/readme-pe/project_euler/README.md
In line with the following comments:
Describe your change:
Checklist: