Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md for Project Euler #3256

Merged
merged 6 commits into from
Oct 15, 2020

Conversation

dhruvmanila
Copy link
Member

@dhruvmanila dhruvmanila commented Oct 13, 2020

To see what it looks like: https://github.com/dhruvmanila/Python/blob/readme-pe/project_euler/README.md

In line with the following comments:

Describe your change:

  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.

@TravisBuddy
Copy link

Travis tests have failed

Hey @dhruvmanila,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: caff6b60-0dc4-11eb-9111-f326d0cb7f09

@dhruvmanila dhruvmanila reopened this Oct 14, 2020
@TravisBuddy
Copy link

Travis tests have failed

Hey @dhruvmanila,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: 6be7cdb0-0dd9-11eb-964d-5d54b4986782

@dhruvmanila dhruvmanila reopened this Oct 14, 2020
@dhruvmanila
Copy link
Member Author

Hey, @cclauss Can you take a look at this? Thanks if you do.

@dhruvmanila dhruvmanila added the awaiting reviews This PR is ready to be reviewed label Oct 14, 2020
@dhruvmanila dhruvmanila marked this pull request as ready for review October 15, 2020 01:43
@dhruvmanila dhruvmanila requested a review from poyea October 15, 2020 01:43
Copy link
Member

@poyea poyea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's cool. I just add a few suggestions on wording, etc. Thank you for your pull request!🤩

dhruvmanila and others added 2 commits October 15, 2020 09:19
Co-authored-by: John Law <johnlaw.po@gmail.com>
@dhruvmanila dhruvmanila removed the awaiting reviews This PR is ready to be reviewed label Oct 15, 2020
@dhruvmanila dhruvmanila merged commit 2d7e08e into TheAlgorithms:master Oct 15, 2020
@dhruvmanila dhruvmanila deleted the readme-pe branch October 15, 2020 04:18
dhruvmanila pushed a commit that referenced this pull request Oct 15, 2020
* Added solution for Project Euler problem 113. #2695

* Updated formatting and doctests. Reference: #3256
dhruvmanila pushed a commit that referenced this pull request Oct 15, 2020
* Added solution for Project Euler problemm problem 173. #2695

* Added docstring

* Update formatting, doctest and annotations. Reference: #3256
dhruvmanila pushed a commit that referenced this pull request Oct 15, 2020
* Added solution for Project Euler problem 74. Fixes: #2695

* Added doctest for solution() in project_euler/problem_74/sol1.py

* Update docstrings and 0-padding of directory name. Reference: #3256
dhruvmanila pushed a commit that referenced this pull request Oct 16, 2020
* Added solution for Project Euler problem 72.

* Update type annotations and 0-padding of the directory name. Reference: #3256

* Rename sol1.py to sol2.py

* Added newline at the end of sol2.py

* Revert sol1.py
dhruvmanila added a commit that referenced this pull request Oct 16, 2020
* Added solution for Project Euler problem 174. 

* Fixed import order and removed executable permission from sol1.py

* Update docstrings, doctests, and annotations. Reference: #3256

* Update docstring

* Update sol1.py

Co-authored-by: Dhruv <dhruvmanila@gmail.com>
dhruvmanila added a commit that referenced this pull request Oct 16, 2020
* Added solution for Project Euler problem 91. Reference: #2695

* Added doctest for solution() in project_euler/problem_91/sol1.py

* Update docstring and 0-padding in directory name. Reference: #3256

* Update sol1.py

Co-authored-by: Dhruv <dhruvmanila@gmail.com>
dhruvmanila pushed a commit that referenced this pull request Oct 16, 2020
* Added solution for Project Euler problem 75. 

* Added doctest for solution() in project_euler/problem_75/sol1.py

* Update docstring and 0-padding of directory name. Reference: #3256

* More descriptive variable names

* Moved solution explanation to module-level docstring
dhruvmanila pushed a commit that referenced this pull request Oct 24, 2020
* Added solution for Project Euler problem 38. Fixes: #2695

* Update docstring and 0-padding in directory name. Reference: #3256

* Renamed is_9_palindromic to is_9_pandigital.

* Changed just-in-case return value for solution() to None.

* Moved exmplanation to module-level docstring and deleted unnecessary import
stokhos pushed a commit to stokhos/Python that referenced this pull request Jan 3, 2021
* Added solution for Project Euler problemm problem 173. TheAlgorithms#2695

* Added docstring

* Update formatting, doctest and annotations. Reference: TheAlgorithms#3256
stokhos pushed a commit to stokhos/Python that referenced this pull request Jan 3, 2021
* Added solution for Project Euler problem 74. Fixes: TheAlgorithms#2695

* Added doctest for solution() in project_euler/problem_74/sol1.py

* Update docstrings and 0-padding of directory name. Reference: TheAlgorithms#3256
stokhos pushed a commit to stokhos/Python that referenced this pull request Jan 3, 2021
* Added solution for Project Euler problem 72.

* Update type annotations and 0-padding of the directory name. Reference: TheAlgorithms#3256

* Rename sol1.py to sol2.py

* Added newline at the end of sol2.py

* Revert sol1.py
stokhos pushed a commit to stokhos/Python that referenced this pull request Jan 3, 2021
* Added solution for Project Euler problem 174. 

* Fixed import order and removed executable permission from sol1.py

* Update docstrings, doctests, and annotations. Reference: TheAlgorithms#3256

* Update docstring

* Update sol1.py

Co-authored-by: Dhruv <dhruvmanila@gmail.com>
stokhos pushed a commit to stokhos/Python that referenced this pull request Jan 3, 2021
* Added solution for Project Euler problem 91. Reference: TheAlgorithms#2695

* Added doctest for solution() in project_euler/problem_91/sol1.py

* Update docstring and 0-padding in directory name. Reference: TheAlgorithms#3256

* Update sol1.py

Co-authored-by: Dhruv <dhruvmanila@gmail.com>
stokhos pushed a commit to stokhos/Python that referenced this pull request Jan 3, 2021
* Added solution for Project Euler problem 75. 

* Added doctest for solution() in project_euler/problem_75/sol1.py

* Update docstring and 0-padding of directory name. Reference: TheAlgorithms#3256

* More descriptive variable names

* Moved solution explanation to module-level docstring
stokhos pushed a commit to stokhos/Python that referenced this pull request Jan 3, 2021
* Added solution for Project Euler problem 38. Fixes: TheAlgorithms#2695

* Update docstring and 0-padding in directory name. Reference: TheAlgorithms#3256

* Renamed is_9_palindromic to is_9_pandigital.

* Changed just-in-case return value for solution() to None.

* Moved exmplanation to module-level docstring and deleted unnecessary import
stokhos pushed a commit to stokhos/Python that referenced this pull request Jan 3, 2021
* Added solution for Project Euler problem 87. Fixes: TheAlgorithms#2695

* Update docstring and 0-padding in directory name. Reference: TheAlgorithms#3256
stokhos pushed a commit to stokhos/Python that referenced this pull request Jan 3, 2021
* Added solution for Project Euler problem 129. 
* Added doctest for solution() in project_euler/problem_129/sol1.py
* Update formatting. Reference: TheAlgorithms#3256 
* More descriptive function and variable names, more doctests.
stokhos pushed a commit to stokhos/Python that referenced this pull request Jan 3, 2021
* Added solution for Project Euler problem 77.

* Update docstrings, doctest, type annotations and 0-padding in directory name. Reference: TheAlgorithms#3256

* Implemented lru_cache, better type hints, more doctests for problem 77

* updating DIRECTORY.md

* updating DIRECTORY.md

* Added solution for Project Euler problem 77. Fixes: 2695

* Update docstrings, doctest, type annotations and 0-padding in directory name. Reference: TheAlgorithms#3256

* Implemented lru_cache, better type hints, more doctests for problem 77

* better variable names

Co-authored-by: github-actions <${GITHUB_ACTOR}@users.noreply.github.com>
peRFectBeliever pushed a commit to peRFectBeliever/Python that referenced this pull request Apr 1, 2021
* Added solution for Project Euler problem 38. Fixes: TheAlgorithms#2695

* Update docstring and 0-padding in directory name. Reference: TheAlgorithms#3256

* Renamed is_9_palindromic to is_9_pandigital.

* Changed just-in-case return value for solution() to None.

* Moved exmplanation to module-level docstring and deleted unnecessary import
peRFectBeliever pushed a commit to peRFectBeliever/Python that referenced this pull request Apr 1, 2021
* Added solution for Project Euler problem 87. Fixes: TheAlgorithms#2695

* Update docstring and 0-padding in directory name. Reference: TheAlgorithms#3256
peRFectBeliever pushed a commit to peRFectBeliever/Python that referenced this pull request Apr 1, 2021
* Added solution for Project Euler problem 129. 
* Added doctest for solution() in project_euler/problem_129/sol1.py
* Update formatting. Reference: TheAlgorithms#3256 
* More descriptive function and variable names, more doctests.
peRFectBeliever pushed a commit to peRFectBeliever/Python that referenced this pull request Apr 1, 2021
* Added solution for Project Euler problem 77.

* Update docstrings, doctest, type annotations and 0-padding in directory name. Reference: TheAlgorithms#3256

* Implemented lru_cache, better type hints, more doctests for problem 77

* updating DIRECTORY.md

* updating DIRECTORY.md

* Added solution for Project Euler problem 77. Fixes: 2695

* Update docstrings, doctest, type annotations and 0-padding in directory name. Reference: TheAlgorithms#3256

* Implemented lru_cache, better type hints, more doctests for problem 77

* better variable names

Co-authored-by: github-actions <${GITHUB_ACTOR}@users.noreply.github.com>
Panquesito7 pushed a commit to Panquesito7/Python that referenced this pull request May 13, 2021
* Update README.md for Project Euler

* Add link to solution template

* Add newlines for better separation

* Add __name__ == __main__ block in template

* Apply suggestions from code review

Co-authored-by: John Law <johnlaw.po@gmail.com>

* Improve introduction part

Co-authored-by: John Law <johnlaw.po@gmail.com>
Panquesito7 pushed a commit to Panquesito7/Python that referenced this pull request May 13, 2021
* Added solution for Project Euler problem 113. TheAlgorithms#2695

* Updated formatting and doctests. Reference: TheAlgorithms#3256
Panquesito7 pushed a commit to Panquesito7/Python that referenced this pull request May 13, 2021
* Added solution for Project Euler problemm problem 173. TheAlgorithms#2695

* Added docstring

* Update formatting, doctest and annotations. Reference: TheAlgorithms#3256
Panquesito7 pushed a commit to Panquesito7/Python that referenced this pull request May 13, 2021
* Added solution for Project Euler problem 74. Fixes: TheAlgorithms#2695

* Added doctest for solution() in project_euler/problem_74/sol1.py

* Update docstrings and 0-padding of directory name. Reference: TheAlgorithms#3256
Panquesito7 pushed a commit to Panquesito7/Python that referenced this pull request May 13, 2021
* Added solution for Project Euler problem 72.

* Update type annotations and 0-padding of the directory name. Reference: TheAlgorithms#3256

* Rename sol1.py to sol2.py

* Added newline at the end of sol2.py

* Revert sol1.py
Panquesito7 pushed a commit to Panquesito7/Python that referenced this pull request May 13, 2021
* Added solution for Project Euler problem 174. 

* Fixed import order and removed executable permission from sol1.py

* Update docstrings, doctests, and annotations. Reference: TheAlgorithms#3256

* Update docstring

* Update sol1.py

Co-authored-by: Dhruv <dhruvmanila@gmail.com>
Panquesito7 pushed a commit to Panquesito7/Python that referenced this pull request May 13, 2021
* Added solution for Project Euler problem 91. Reference: TheAlgorithms#2695

* Added doctest for solution() in project_euler/problem_91/sol1.py

* Update docstring and 0-padding in directory name. Reference: TheAlgorithms#3256

* Update sol1.py

Co-authored-by: Dhruv <dhruvmanila@gmail.com>
Panquesito7 pushed a commit to Panquesito7/Python that referenced this pull request May 13, 2021
* Added solution for Project Euler problem 75. 

* Added doctest for solution() in project_euler/problem_75/sol1.py

* Update docstring and 0-padding of directory name. Reference: TheAlgorithms#3256

* More descriptive variable names

* Moved solution explanation to module-level docstring
Panquesito7 pushed a commit to Panquesito7/Python that referenced this pull request May 13, 2021
* Added solution for Project Euler problem 38. Fixes: TheAlgorithms#2695

* Update docstring and 0-padding in directory name. Reference: TheAlgorithms#3256

* Renamed is_9_palindromic to is_9_pandigital.

* Changed just-in-case return value for solution() to None.

* Moved exmplanation to module-level docstring and deleted unnecessary import
Panquesito7 pushed a commit to Panquesito7/Python that referenced this pull request May 13, 2021
* Added solution for Project Euler problem 87. Fixes: TheAlgorithms#2695

* Update docstring and 0-padding in directory name. Reference: TheAlgorithms#3256
Panquesito7 pushed a commit to Panquesito7/Python that referenced this pull request May 13, 2021
* Added solution for Project Euler problem 129. 
* Added doctest for solution() in project_euler/problem_129/sol1.py
* Update formatting. Reference: TheAlgorithms#3256 
* More descriptive function and variable names, more doctests.
Panquesito7 pushed a commit to Panquesito7/Python that referenced this pull request May 13, 2021
* Added solution for Project Euler problem 77.

* Update docstrings, doctest, type annotations and 0-padding in directory name. Reference: TheAlgorithms#3256

* Implemented lru_cache, better type hints, more doctests for problem 77

* updating DIRECTORY.md

* updating DIRECTORY.md

* Added solution for Project Euler problem 77. Fixes: 2695

* Update docstrings, doctest, type annotations and 0-padding in directory name. Reference: TheAlgorithms#3256

* Implemented lru_cache, better type hints, more doctests for problem 77

* better variable names

Co-authored-by: github-actions <${GITHUB_ACTOR}@users.noreply.github.com>
shermanhui pushed a commit to shermanhui/Python that referenced this pull request Oct 22, 2021
* Added solution for Project Euler problem 38. Fixes: TheAlgorithms#2695

* Update docstring and 0-padding in directory name. Reference: TheAlgorithms#3256

* Renamed is_9_palindromic to is_9_pandigital.

* Changed just-in-case return value for solution() to None.

* Moved exmplanation to module-level docstring and deleted unnecessary import
shermanhui pushed a commit to shermanhui/Python that referenced this pull request Oct 22, 2021
* Added solution for Project Euler problem 87. Fixes: TheAlgorithms#2695

* Update docstring and 0-padding in directory name. Reference: TheAlgorithms#3256
shermanhui pushed a commit to shermanhui/Python that referenced this pull request Oct 22, 2021
* Added solution for Project Euler problem 129. 
* Added doctest for solution() in project_euler/problem_129/sol1.py
* Update formatting. Reference: TheAlgorithms#3256 
* More descriptive function and variable names, more doctests.
shermanhui pushed a commit to shermanhui/Python that referenced this pull request Oct 22, 2021
* Added solution for Project Euler problem 77.

* Update docstrings, doctest, type annotations and 0-padding in directory name. Reference: TheAlgorithms#3256

* Implemented lru_cache, better type hints, more doctests for problem 77

* updating DIRECTORY.md

* updating DIRECTORY.md

* Added solution for Project Euler problem 77. Fixes: 2695

* Update docstrings, doctest, type annotations and 0-padding in directory name. Reference: TheAlgorithms#3256

* Implemented lru_cache, better type hints, more doctests for problem 77

* better variable names

Co-authored-by: github-actions <${GITHUB_ACTOR}@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants