-
Notifications
You must be signed in to change notification settings - Fork 756
[Docs] Added OR messages glossary #3506
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: luarss <espsluar@gmail.com>
Signed-off-by: luarss <espsluar@gmail.com>
|
@vvbandeira Can I check if its okay to repeat the same code if they are different types? e.g. DFT 0004 |
|
No they should not repeat. Each message should be unique regardless of type |
docs/getMessages.sh
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it be too much of an inconvenience to do this in Python instead of shell? Then we could tightly integrate with the existing find_messages.py and avoid depending on temporary files.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vvbandeira Yes, that's possible but i'm not sure if find_messages.py is being used by other parts of the codebase right now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is being used by CMake here. But you do not need to modify it I think, maybe you can just import it as a module.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vvbandeira Added a prototype for getMessages.py. Its hacky but at least we generate one less temporary file
Signed-off-by: luarss <espsluar@gmail.com>
Signed-off-by: luarss <espsluar@gmail.com>
permalink is very useful. We had also discussed making them actionable. What is the current plan for that? |
|
@dralabeing We can do the following:
Feel free to suggest more |
|
Marking it as a draft for now as we need to discuss a little more on the goals here. @dralabeing I don't think making changes to the messages is in the scope of this PR or the work @luarss is doing. @luarss individual tables for each tool would indeed be nice, or you could just append them as a new section in the tool's README as a new section. Or we could have it as a separate file for each tool and add them in the toc as a subitem for each tool. |
Sounds good. It could be both right? table+ tool README. This would give the user multiple ways to track messages. However, open to suggestions however in terms of best ways to organize this. |
…rrors Signed-off-by: luarss <espsluar@gmail.com>
Signed-off-by: luarss <espsluar@gmail.com>
Signed-off-by: luarss <espsluar@gmail.com>
|
@vvbandeira @dralabeing I have added a prototype for how a tool developer could potentially add additional user guidance in their respective repositories. Key features
Also, I realised a bug with the PR docs 1. We cannot see the file |
Signed-off-by: luarss <espsluar@gmail.com>
Signed-off-by: luarss <espsluar@gmail.com>
Signed-off-by: luarss <espsluar@gmail.com>
Signed-off-by: luarss <espsluar@gmail.com>
|
@vvbandeira Updated, now it looks like this |
vvbandeira
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks very good @luarss.
Let's replace the ant and cts placeholders with these two following messages from grt:
GRT 0118 GlobalRouter.cpp:331 Routing congestion too high. Check the congestion heatmap in the GUI.
GRT 0119 GlobalRouter.cpp:324 Routing congestion too high. Check the congestion heatmap in the GUI and load {} in the DRC viewer.
For these messages, we can point the user on how to open the GUI, reference a section in the Flow tutorial for example. We can also give suggestions such as trying to reduce the GPL density target.
Signed-off-by: luarss <espsluar@gmail.com>
I think that these This looks great and is an example of the above. Here we can add the links to the GUI with the instructions. Later, other developers can add tips to users on which knobs to turn to avoid the error message. FYI @maliberty, @vijayank88. We can start curating information that we often see in issues and discussions to add to the table. Congestion is a big one that I often see repeating in many places. |
Signed-off-by: luarss <espsluar@gmail.com>
Signed-off-by: luarss <espsluar@gmail.com>
Signed-off-by: luarss <espsluar@gmail.com>
Signed-off-by: luarss <espsluar@gmail.com>
|
@vvbandeira Merge conflict is resolved, ready for review |
Signed-off-by: Vitor Bandeira <vvbandeira@precisioninno.com>



Goal is to add OR error codes/warning codes to OR docs.
Todo
@vvbandeira @dralabeing @vijayank88