Skip to content

Conversation

@luarss
Copy link
Contributor

@luarss luarss commented Jun 22, 2023

Goal is to add OR error codes/warning codes to OR docs.

Todo

  • Add in permalink to where you may find each
  • How to add more value to the messages?

@vvbandeira @dralabeing @vijayank88

Signed-off-by: luarss <espsluar@gmail.com>
@luarss luarss changed the title Added OR messages glossary [Docs] Added OR messages glossary Jun 24, 2023
Signed-off-by: luarss <espsluar@gmail.com>
@luarss
Copy link
Contributor Author

luarss commented Jun 25, 2023

@maliberty
Copy link
Member

No they should not repeat. Each message should be unique regardless of type

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be too much of an inconvenience to do this in Python instead of shell? Then we could tightly integrate with the existing find_messages.py and avoid depending on temporary files.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vvbandeira Yes, that's possible but i'm not sure if find_messages.py is being used by other parts of the codebase right now

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is being used by CMake here. But you do not need to modify it I think, maybe you can just import it as a module.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vvbandeira Added a prototype for getMessages.py. Its hacky but at least we generate one less temporary file

luarss added 4 commits June 27, 2023 01:35
Signed-off-by: luarss <espsluar@gmail.com>
Signed-off-by: luarss <espsluar@gmail.com>
Signed-off-by: luarss <espsluar@gmail.com>
@dralabeing
Copy link
Contributor

Goal is to add OR error codes/warning codes to OR docs.

Todo

  • Add in permalink to where you may find each
  • How to add more value to the messages?

@vvbandeira @dralabeing @vijayank88

permalink is very useful. We had also discussed making them actionable. What is the current plan for that?

@luarss
Copy link
Contributor Author

luarss commented Jun 28, 2023

@dralabeing We can do the following:

  • Advice for some warnings/errors <- I am not an expert in EDA, so will need help in this
  • Categorise nicely; i.e. create different sections & tables for different tools

Feel free to suggest more

@vvbandeira vvbandeira marked this pull request as draft June 28, 2023 22:22
@vvbandeira
Copy link
Member

Marking it as a draft for now as we need to discuss a little more on the goals here.


@dralabeing I don't think making changes to the messages is in the scope of this PR or the work @luarss is doing.
The goal of this PR is to provide a way to grab the messages from the tools and add them to the docs automatically, we will define how tool developers should annotate their code to include in the docs, for example.


@luarss individual tables for each tool would indeed be nice, or you could just append them as a new section in the tool's README as a new section. Or we could have it as a separate file for each tool and add them in the toc as a subitem for each tool.

@dralabeing
Copy link
Contributor

Marking it as a draft for now as we need to discuss a little more on the goals here.

@dralabeing I don't think making changes to the messages is in the scope of this PR or the work @luarss is doing. The goal of this PR is to provide a way to grab the messages from the tools and add them to the docs automatically, we will define how tool developers should annotate their code to include in the docs, for example.

@luarss individual tables for each tool would indeed be nice, or you could just append them as a new section in the tool's README as a new section. Or we could have it as a separate file for each tool and add them in the toc as a subitem for each tool.

Sounds good. It could be both right? table+ tool README. This would give the user multiple ways to track messages. However, open to suggestions however in terms of best ways to organize this.

luarss added 3 commits July 1, 2023 23:12
…rrors

Signed-off-by: luarss <espsluar@gmail.com>
Signed-off-by: luarss <espsluar@gmail.com>
Signed-off-by: luarss <espsluar@gmail.com>
@luarss
Copy link
Contributor Author

luarss commented Jul 1, 2023

@vvbandeira @dralabeing I have added a prototype for how a tool developer could potentially add additional user guidance in their respective repositories.

Key features

  • createNewMsgs.sh: this will create "information" files in each tool dir (src/<tool>/doc/messages/xxxx.md) if it doesn't already exist
  • getMessages.py: will look for these "information" file and place it the "Information" column. If no content, just put a "-"

Also, I realised a bug with the PR docs 1. We cannot see the file user/MessagesFinal.md right now because readthedocs does not actually do the compilation every time, it simply takes what is in the repo - parsed by conf.py. So we do have to include that file after all.

luarss added 4 commits July 2, 2023 00:46
Signed-off-by: luarss <espsluar@gmail.com>
Signed-off-by: luarss <espsluar@gmail.com>
Signed-off-by: luarss <espsluar@gmail.com>
Signed-off-by: luarss <espsluar@gmail.com>
@luarss
Copy link
Contributor Author

luarss commented Jul 7, 2023

@vvbandeira Updated, now it looks like this
image

@luarss luarss marked this pull request as ready for review July 7, 2023 17:09
Copy link
Member

@vvbandeira vvbandeira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks very good @luarss.
Let's replace the ant and cts placeholders with these two following messages from grt:

GRT 0118 GlobalRouter.cpp:331      Routing congestion too high. Check the congestion heatmap in the GUI.
GRT 0119 GlobalRouter.cpp:324      Routing congestion too high. Check the congestion heatmap in the GUI and load {} in the DRC viewer.

For these messages, we can point the user on how to open the GUI, reference a section in the Flow tutorial for example. We can also give suggestions such as trying to reduce the GPL density target.

Signed-off-by: luarss <espsluar@gmail.com>
@luarss
Copy link
Contributor Author

luarss commented Jul 11, 2023

Those aren't really placeholders. At least for some of them I think the deprecated keyword suggestion is useful to leave in?

Anyways, here's what I came up for GRT
image

@vvbandeira
Copy link
Member

Those aren't really placeholders. At least for some of them I think the deprecated keyword suggestion is useful to leave in?

I think that these cts and ant are short enough to include in the message themselves. The main goal of the table and separated md files would be to add long descriptions with details, rich formatting and useful links that are "extra" and do not fit in the message context.

Anyways, here's what I came up for GRT image

This looks great and is an example of the above. Here we can add the links to the GUI with the instructions. Later, other developers can add tips to users on which knobs to turn to avoid the error message.


FYI @maliberty, @vijayank88. We can start curating information that we often see in issues and discussions to add to the table. Congestion is a big one that I often see repeating in many places.

Signed-off-by: luarss <espsluar@gmail.com>
@luarss luarss marked this pull request as draft July 13, 2023 16:23
@luarss luarss marked this pull request as ready for review July 13, 2023 16:23
luarss added 3 commits July 14, 2023 01:13
Signed-off-by: luarss <espsluar@gmail.com>
Signed-off-by: luarss <espsluar@gmail.com>
Signed-off-by: luarss <espsluar@gmail.com>
@luarss
Copy link
Contributor Author

luarss commented Jul 15, 2023

@vvbandeira Merge conflict is resolved, ready for review

Signed-off-by: Vitor Bandeira <vvbandeira@precisioninno.com>
@vvbandeira vvbandeira merged commit 6fbc84f into The-OpenROAD-Project:master Jul 19, 2023
@luarss luarss deleted the OR_messages branch August 26, 2023 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants