Rename -[ASCellNode viewModel] to -[ASCellNode nodeViewModel] to avoid collisions #499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 7, 2017 09:45
…d breaking existing code
|
Thank you, that was really fast! 🎉 |
maicki
approved these changes
Aug 7, 2017
Adlai-Holler
added a commit
that referenced
this pull request
Aug 15, 2017
bernieperez
pushed a commit
to AtomTickets/Texture
that referenced
this pull request
Apr 25, 2018
…d collisions (TextureGroup#499) * Rename -[ASCellNode viewModel] -> -[ASCellNode nodeViewModel] to avoid breaking existing code * Update test * Update the changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks to @Kaspik and slack users mlilek, jdeguzman, and emre for reporting the issues this collision has caused in their apps.
This is an implementation of a proposal from @Kaspik to rename the field to
nodeViewModel. This will be a breaking change for users who have already modified their product code to account for the collision.As the implementor of the
viewModelfield, I take responsibility for all the effort y'all went through to adapt to it. Sorry. Hopefully this patch isn't too late to save some of you a lot of effort.Everyone let me know what you think about this.