Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BETA viewModel] View model overriding #498

Closed
Kaspik opened this issue Aug 7, 2017 · 1 comment
Closed

[BETA viewModel] View model overriding #498

Kaspik opened this issue Aug 7, 2017 · 1 comment

Comments

@Kaspik
Copy link
Contributor

Kaspik commented Aug 7, 2017

Hey @Adlai-Holler ! I already wrote you on Slack, but you are not using it probably, so I'll post it here as public question as I think I'll not be the only one.

Regarding BETA viewModels on cells ( #356 )
It was merged to version 2.3.4 - so it’s currently in production.
We (as a lot of another users I believe) use view models normally even without Texture support. But if I update to 2.3.4 Texture - I can’t build the app.
It’s because we have property viewModel on node as a (strong, nonatomic) and it needs @dynamic or rename and rewrite to get it working with new Texture. I don’t want to use dynamic to get it working as your property is defined differently (atomic, nullable) + it’s still beta, and I don’t wanna rewrite all cells to have differently named property. I think I’m not the only one facing this problem and decision.
Would it be possible to instead of viewModel as default property by texture use for example nodeViewModel name? Wouldn’t it be better as well if you introduce viewModel for controllers etc - then all of them named based on what kind of viewModel it is?

Sorry that this is half-issue and half-question. But I would like to know where viewModels are going on Texture.

@Kaspik
Copy link
Contributor Author

Kaspik commented Aug 7, 2017

Fixed in #499 - closing :)

@Kaspik Kaspik closed this as completed Aug 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant